Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OPENAL optional also on non-windows platforms #943

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Make OPENAL optional also on non-windows platforms #943

merged 1 commit into from
Mar 25, 2024

Conversation

th-otto
Copy link
Contributor

@th-otto th-otto commented Mar 16, 2024

There are some system where OPENAL is not available

OmniBlade
OmniBlade requested changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@OmniBlade OmniBlade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to make OpenAL optional for all platforms, just move the option out of the conditional block and into the cross platform options above it? I would prefer that than the option be duplicated between the windows and none windows conditions.

@th-otto @OmniBlade
Make OPENAL optional also on non-windows platforms
bd2cc9f 
There are some system where OPENAL is not available
@OmniBlade OmniBlade merged commit 0d6fee7 into TheAssemblyArmada:vanilla Mar 25, 2024
10 checks passed
@th-otto th-otto deleted the PR-1 branch March 25, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmniBlade OmniBlade OmniBlade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@th-otto @OmniBlade