Fix compilation of the editors when using SDL1 #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, build fails in the clang format check, but the lines that are marked (https://github.com/TheAssemblyArmada/Vanilla-Conquer/actions/runs/8308506496/job/22740736584#step:7:810) are not touched by the patch? |
|
Looks like the added ifdef is confusing clang-format? Maybe add a line break after the comment block and see if that makes it happy? |
|
Nope, didn't work. |
|
But moving the block inside the ifdef worked. I guess clang-format wants the comment to be aligned with the case label, and got confused by the preprocessor statement. |
OmniBlade
approved these changes
Mar 20, 2024
SHIFT-HOME and HOME have the same values for SDL1; use CTRL-HOME instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHIFT-HOME and HOME have the same values for SDL1; use CTRL-HOME instead