Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid conflicing redefinitions of strupr() & strrev() #948

Open
wants to merge 1 commit into
base: vanilla
Choose a base branch
from

Conversation

th-otto
Copy link
Contributor

@th-otto th-otto commented Mar 16, 2024

No description provided.

@OmniBlade
Copy link
Contributor

#820 would resolve this by detecting these and other platform specific functions at configure time so no need for platform specifics, but needs reviewing and merging.

@th-otto
Copy link
Contributor Author

th-otto commented Mar 25, 2024

Yes, i agree, there are certainly better ways to fix this, my approach was just to fix compilation on MiNT (it complains because it was already declared in <string.h> and then declared static in wwstd.h), without breaking other platforms.

Another simple solution might be to just use different name, like is done with _strlwr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants