Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard handling for SDL1 #974

Open
wants to merge 1 commit into
base: vanilla
Choose a base branch
from

Conversation

th-otto
Copy link
Contributor

@th-otto th-otto commented Mar 24, 2024

A lot of scancodes in SDL1 are > 256. The current code assumed in a lot of places that they are less than 256, causing eg. ctrl-key combination not to work.

Also the the sdl_keymap array for translating keysyms to ascii was only suitable for SDL2.

@th-otto
Copy link
Contributor Author

th-otto commented Mar 24, 2024

Unfortunately this PR will conflict with #957

Please let me know of you want to merge that PR first, then i will refactor the code

A lot of scancodes in SDL1 are > 256. The current code assumed in a lot
of places that they are less than 256, causing eg. ctrl-key combination
not to work.

Also the the sdl_keymap array for translating keysyms to ascii was only
suitable for SDL2.
@OmniBlade
Copy link
Contributor

I merged the other PR first, feel free to update this PR.

@arczi84
Copy link

arczi84 commented Sep 8, 2024

I have used your fix in my branch merged with main one but can't scroll map with keyboard arrows. Can you test that on your end?

EDIT: Changing key numbers in .ini file fixed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants