(chocolatey#508) Make package id comparisons case insensitive

This helps ensure that package IDs are handled in a case insensitive manner.
TheCakeIsNaOH · Jan 9, 2024 · ecaaf15 · ecaaf15
1 parent a7f72e0
commit ecaaf15
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/chocolatey/infrastructure.app/services/NugetService.cs b/src/chocolatey/infrastructure.app/services/NugetService.cs
@@ -499,7 +499,7 @@ public virtual ConcurrentDictionary<string, PackageResult> Install(ChocolateyCon
             if (packageNames.Count == 1)
             {
                 var packageName = packageNames.DefaultIfEmpty(string.Empty).FirstOrDefault();
-                if (packageName.EndsWith(NuGetConstants.PackageExtension) || packageName.EndsWith(PackagingConstants.ManifestExtension))
+                if (packageName.EndsWith(NuGetConstants.PackageExtension, StringComparison.OrdinalIgnoreCase) || packageName.EndsWith(PackagingConstants.ManifestExtension, StringComparison.OrdinalIgnoreCase))
                 {
                     this.Log().Warn(ChocolateyLoggers.Important, "DEPRECATION WARNING");
                     this.Log().Warn(InstallWithFilePathDeprecationMessage);
@@ -509,7 +509,7 @@ public virtual ConcurrentDictionary<string, PackageResult> Install(ChocolateyCon
 
                     config.Sources = _fileSystem.GetDirectoryName(_fileSystem.GetFullPath(packageName));
 
-                    if (packageName.EndsWith(PackagingConstants.ManifestExtension))
+                    if (packageName.EndsWith(PackagingConstants.ManifestExtension, StringComparison.OrdinalIgnoreCase))
                     {
                         packageNames.Add(_fileSystem.GetFilenameWithoutExtension(packageName));
 
@@ -553,7 +553,7 @@ public virtual ConcurrentDictionary<string, PackageResult> Install(ChocolateyCon
 
                 var installedPackage = allLocalPackages.FirstOrDefault(p => p.Name.IsEqualTo(packageName));
 
-                if (Platform.GetPlatform() != PlatformType.Windows && !packageName.EndsWith(".template"))
+                if (Platform.GetPlatform() != PlatformType.Windows && !packageName.EndsWith(".template", StringComparison.OrdinalIgnoreCase))
                 {
                     string logMessage = "{0} is not a supported package on non-Windows systems.{1}Only template packages are currently supported.".FormatWith(packageName, Environment.NewLine);
                     this.Log().Warn(ChocolateyLoggers.Important, logMessage);