Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1020 add support for Date-Type by min/maxDate in dateTimePicker #1136

Closed
wants to merge 3 commits into from

Conversation

geopossachs
Copy link
Collaborator

No description provided.

@geopossachs geopossachs added this to the v1.5.0 milestone May 1, 2020
@stephanrauh
Copy link
Collaborator

Do we have to modify the BootFaces.jsfdsl file, too?

I also wonder if the signature of the setter is OK. What happens when you call setMaxDate(String) with a date? Did I miss something?

While you're at it: should we support the new Java8 Date/Time API, too?

@geopossachs
Copy link
Collaborator Author

Do we have to modify the BootFaces.jsfdsl file, too?

It is possible to accept String and Date twice?

I also wonder if the signature of the setter is OK. What happens when you call setMaxDate(String) with a date? Did I miss something?

i have use <f:attribute name="minDate" value="#{register.dateOfBirth}" /> and so i can set a Date()

While you're at it: should we support the new Java8 Date/Time API, too?

i would prefer Java8 Date/Time API in the next Version 1.6

@stephanrauh
Copy link
Collaborator

It is possible to accept String and Date twice?

That's the domain of languages like TypeScript. :)

I guess it should be possible to define two setters, one for each type. However, there's no easy fix for the getter. Probably it's best to simply use the least common denominator Object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dateTimePicker min/maxDate types are not all supported or wrongly documented
2 participants