Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log to logger before Discord #141

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

nullishamy
Copy link
Collaborator

This adjusts our uncaught exception handler to be more useful. Previously, it would try logging to Discord before the pino logger.
This is problematic because if we encounter problems before d.js is up (e.g with Prisma) they will fail to log, as the internalLog is not ready.

@nullishamy nullishamy requested a review from a team as a code owner January 28, 2024 19:37
@BobobUnicorn BobobUnicorn merged commit 9695415 into master Feb 12, 2024
1 check passed
@BobobUnicorn BobobUnicorn deleted the fix/uncaught-exception-logging branch February 12, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants