Particle Cloud Improvements#1006
Merged
TonytheMacaroni merged 9 commits intoTheComputerGeek2:mainfrom Mar 31, 2025
Merged
Conversation
core/src/main/java/com/nisovin/magicspells/spelleffects/effecttypes/ParticleCloudEffect.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/nisovin/magicspells/spelleffects/effecttypes/ParticleCloudEffect.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/nisovin/magicspells/spells/targeted/ParticleCloudSpell.java
Outdated
Show resolved
Hide resolved
|
Built artifact: |
JasperLorelai
force-pushed
the
main
branch
2 times, most recently
from
c123511 to
3b6809b
Compare
- Added "dust_color_transition" config options. - Added "argb-color" for "entity_effect". - Particles and their color must be set after potion effects. Color should be set when setting the particle, rather than with "AreaEffectCloud#setColor". - Returns "particle-name" option accidentally removed in 4.0 Beta 13 when renamed to "particle".
Merged
TonytheMacaroni
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Changes:
ParticleCloudSpelloptionpotion-effectsnow relies on the common Potion Effects List format, which causes a minor breaking change in the string variant of the format (<potion> <duration> <amplifier> <ambient> <particles> <icon>), whereambientnow refers toggleshidden, andparticlesnow togglesambient.Changes:
particlecloudspell effect can now utilise theargb-coloroption to color theentity_effectparticle.particle-nameoption toParticleCloudSpellas an alias to theparticleoption, as it was unintentionally renamed in4.0 Beta 13.Additions:
potion-effectsto Entity Data.ParticleCloudSpellto configure particles:dust_color_transition-color,to-colorandsizeoptions under adust-transitionsectionentity_effect-argb-coloroptionapply-physicstoReplaceSpell, a boolean option, defaulting totrue.wait-time(Integer, defaults to0) toparticlecloudspell effect. This overrides the default behaviour where radius is ignored for 20 ticks and particles only spawn at the center of the cloud.Fixes:
particlecloudspell effect not playing correctly when played on an entity rather than a location.entity_effectparticle in theParticleCloudSpellbeing overridden by thepotion-effectscolor.