Skip to content

feat: ProxySpell - #1100

Open
DragonsAscent wants to merge 15 commits into
TheComputerGeek2:mainfrom
DragonsAscent:proxy-spell
Open

DragonsAscent wants to merge 15 commits into
TheComputerGeek2:mainfrom
DragonsAscent:proxy-spell

Conversation

@DragonsAscent

Copy link
Copy Markdown
Collaborator

Allows the caster to designate an entity as a "proxy". Any spell / damage will be redirected to the caster treating that entity as if it were the caster themself.

Copilot AI lite review requested due to automatic review settings August 23, 2026 19:09

This comment was marked as resolved.

Comment thread core/src/main/java/com/nisovin/magicspells/spells/buff/ProxySpell.java Outdated
Comment thread core/src/main/java/com/nisovin/magicspells/spells/buff/ProxySpell.java Outdated
Comment thread core/src/main/java/com/nisovin/magicspells/spells/buff/ProxySpell.java Outdated
Comment thread core/src/main/java/com/nisovin/magicspells/spells/buff/ProxySpell.java Outdated
Comment thread core/src/main/java/com/nisovin/magicspells/spells/buff/ProxySpell.java Outdated
Comment thread core/src/main/java/com/nisovin/magicspells/spells/buff/ProxySpell.java Outdated
Comment thread core/src/main/java/com/nisovin/magicspells/spells/buff/ProxySpell.java Outdated
Comment thread core/src/main/java/com/nisovin/magicspells/spells/buff/ProxySpell.java Outdated
@JasperLorelai

Copy link
Copy Markdown
Collaborator

I actually ended up removing the SpellPreImpactEvent handler. SpellTargetEvent is always called before it and already handles the proxy swapping.

Comment thread core/src/main/java/com/nisovin/magicspells/spells/buff/ProxySpell.java Outdated
Comment thread core/src/main/java/com/nisovin/magicspells/spells/buff/ProxySpell.java Outdated
Comment thread core/src/main/java/com/nisovin/magicspells/spells/buff/ProxySpell.java Outdated
DragonsAscent and others added 2 commits August 28, 2026 13:24
@JasperLorelai

Copy link
Copy Markdown
Collaborator

Whoever merges, pls use "Squash & merge" because history messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants