fix: guard DataForSEO handoff in quick wins research#28
Open
Gujiassh wants to merge 1 commit intoTheCraigHewitt:mainfrom
Open
fix: guard DataForSEO handoff in quick wins research#28Gujiassh wants to merge 1 commit intoTheCraigHewitt:mainfrom
Gujiassh wants to merge 1 commit intoTheCraigHewitt:mainfrom
Conversation
Keep the quick-wins workflow stable when DataForSEO returns empty ranking or SERP payloads by validating the first ranking/result before reading from it. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
research_quick_wins.pyfor the first ranking row and SERP feature fetch pathrankings[0]exists when DataForSEO returns an empty list or malformed payloadValidation
python3 -m py_compile research_quick_wins.py tests/test_research_quick_wins_helpers.pypython3 -m unittest tests.test_research_quick_wins_helpersNotes
seomachine#26and#27, which already cover the provider-layer GA and DataForSEO client contracts