[Feature/Port] Reagent Production #68
Open
honeyed-lemons wants to merge 7 commits intoTheDenSS14:masterfrom
Open
[Feature/Port] Reagent Production #68honeyed-lemons wants to merge 7 commits intoTheDenSS14:masterfrom
honeyed-lemons wants to merge 7 commits intoTheDenSS14:masterfrom
Conversation
<!-- Guidelines: https://docs.spacestation14.io/en/getting-started/pr-guideline --> <!-- NOTE: All code submitted to this repository is ALWAYS licensed under the AGPL-3.0-or-later license. The REUSE Specification headers or separate .license files indicate a secondary license (e.g., MPL or MIT) solely to facilitate integration for projects that do not use the AGPL license. This secondary license does not replace the fact that AGPL-3.0-or-later remains the primary and binding license. Uncomment and modify the following line if you wish to change the license from the default of AGPL.--> LICENSE: MIT ## About the PR <!-- What did you change? --> Replaced the usage of the old floof lewdtraitsystem for a new ReagentProductionSystem, which allows for the addition of new production types without the need for c#. This also slightly adjusts the production rates / capacities / expulsion of different reagents to be somewhat realistic (But not really) ## Why / Balance <!-- Discuss how this would affect game balance or explain why it was changed. Link any relevant discussions or issues. --> The old system we have from floof is frankly outdated and unintuitive. This system allows you to simply just right click on any fillable entity and fill it with any one of your available production types, no fuss. ## Technical details <!-- Summary of code changes for easier review. --> Adds the `ReagentProductionSystem` which uses `ReagentProductionTypePrototypes` in order to determine what an entity can or cannot produce, this system allows for any number of arbitrary production types to be added without the need for c#! This PR does not remove the old floof systems, but i can do that if you want ## Media <!-- Attach media if the PR makes ingame changes (clothing, items, features, etc). Small fixes/refactors are exempt. Media may be used in SS14 progress reports with credit. --> Warning: the video i guess is nsfw https://github.com/user-attachments/assets/5b1abda1-b1ea-499d-9fc8-e3137a71c41b ## Requirements <!-- Confirm the following by placing an X in the brackets [X]: --> - [x] I have read and am following the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html). - [x] I have added media to this PR or it does not require an ingame showcase. - [x] I have tested any changes or additions. - [x] I can confirm this PR contains no AI-generated content, and did not use any AI-generated content. <!-- You should understand that not following the above may get your PR closed at maintainer’s discretion --> ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> N/A, traits have been adjusted accordingly and will not need to be replaced. **Changelog** <!-- Add a Changelog entry to make players aware of new features or changes that could affect gameplay. Make sure to read the guidelines and take this Changelog template out of the comment block in order for it to show up. Changelog must have a 🆑 symbol, so the bot recognizes the changes and adds them to the game's changelog. --> 🆑 - tweak: Cumming is more intuitive! Just open the context menu of any fill-able container and go ham (with consent)! (cherry picked from commit 986170b2195c8e046af0b9ad73b3a8e6b7ad8e30)
<!-- Guidelines: https://docs.spacestation14.io/en/getting-started/pr-guideline --> <!-- NOTE: All code submitted to this repository is ALWAYS licensed under the AGPL-3.0-or-later license. The REUSE Specification headers or separate .license files indicate a secondary license (e.g., MPL or MIT) solely to facilitate integration for projects that do not use the AGPL license. This secondary license does not replace the fact that AGPL-3.0-or-later remains the primary and binding license. Uncomment and modify the following line if you wish to change the license from the default of AGPL.--> <!--- LICENSE: AGPL --> ## About the PR <!-- What did you change? --> Code wise, all i've done is make it so verb names are capitalized, however this PR does also: - Add synthetic cum, a type of cum lube, and synthetic lube, a water based lube. - Add Glycerol and Hydroxyethyl Cellulose, ingredients for creating synthetic lube. - Replace space lube in sexual lubricant with synthetic lube. - Add two new traits, one for each new lewd reagents. ## Why / Balance <!-- Discuss how this would affect game balance or explain why it was changed. Link any relevant discussions or issues. --> Capitalize verbs bc verbs are capitalized The new traits / lewd reagents are added to facilitate roleplay with our crew members who cannot naturally produce certain fluids. The new traits are incompatible with their natural counterparts, as to not let you make too many reagents on demand? Is than issue? i dunno. As for why the process for making the new reagents is so complex and (vaugely) realistic? I wanted to. I've made sure it's not possible to accidentally create synthetic lube! ## Technical details <!-- Summary of code changes for easier review. --> Me add capitalization Also I've moved the honey producer trait to den folders because we added it ## Media <!-- Attach media if the PR makes ingame changes (clothing, items, features, etc). Small fixes/refactors are exempt. Media may be used in SS14 progress reports with credit. --> <img width="465" height="160" alt="image" src="https://github.com/user-attachments/assets/7118291b-30cc-49a2-b4e2-e20660a4ddb7" /> ## Requirements <!-- Confirm the following by placing an X in the brackets [X]: --> - [x] I have read and am following the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html). - [x] I have added media to this PR or it does not require an ingame showcase. - [x] I have tested any changes or additions. - [x] I can confirm this PR contains no AI-generated content, and did not use any AI-generated content. <!-- You should understand that not following the above may get your PR closed at maintainer’s discretion --> ## Breaking changes <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> N/A **Changelog** <!-- Add a Changelog entry to make players aware of new features or changes that could affect gameplay. Make sure to read the guidelines and take this Changelog template out of the comment block in order for it to show up. Changelog must have a 🆑 symbol, so the bot recognizes the changes and adds them to the game's changelog. --> 🆑 - add: Traits to produce Synthetic Cum and Synthetic Lube! - add: Synthetic Cum and Synthetic Lube are now able to be made by a fairly complex chemical process. Have fun! (cherry picked from commit 3cf732c73b30c2b103ca5d13b95ad78513a22b4e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
This PR adds a few things:
In the future i want to add a popup on items that have been filled with "lewd" reagents, but this is not included in this PR
If someone could point me in the right direction for those i'd be grateful! Otherwise i will continue working on this later :3
Why / Balance
Why? well.. People want to fill things with their fluids! It's good for them, frankly.
Technical details
Adds the
ReagentProductionSystemwhich usesReagentProductionTypePrototypesin order to determine what an entity can or cannot produce, this system allows for any number of arbitrary production types to be added without the need for c#!Additionally this PR adds a new trait function specifically for reagent production. I didn't want it to be this way, but it's what had to be done.
(Honey stomach stuff is included but not implemented due to there being no fucking honey upstream? what??)
Media
ignore honey stomach stuff
https://github.com/user-attachments/assets/3cd42edd-1e91-4c8b-bd23-064b981b58b6
Requirements
Breaking changes
N/A!
Changelog
🆑