Make PackageProject.cmake installable as utility module #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arniiiii
force-pushed
the
master
branch
2 times, most recently
from
e885cd1 to
47838fd
Compare
add CI test for installed PackageProject.cmake utility module CI: expand a prefix folder to fullpath Style fix CI: expand a relative path to fullpath an attempt to fix WIP an attempt to fix 2 WIP an attempt to fix 3 style fix WIP test WIP maybe pre-final-fix WIP: CI fix WIP: what if install to /usr/local ? Small fix fix: the project is PackageProject.cmake not PackageProject style fix
make CPM_DOWNLOAD_LOCATION overridable
it's necassary, because without it, CMake adds `-lcxxopts` to linker flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make PackageProject.cmake installable as utility module
Also I added CI testing for this.
Why?
I try to switch a lot of my code to be usable from Portage, not CPM. Though Portage has one small restriction: no downloading during configuration.
I could live with this telling CPM where is the PackageProject.cmake folder via
CPM_PackageProject.cmake_SOURCE, but it appeared to be really hard to update: in any "recipe" for every package there will be commit hash of PackageProject.cmake, CPM and maybe some other similar scripts .Thus, now I try to make all such CMake scripts installable.
My notes:
CMake is somewhat hypocritical:
It can have
/usr/share/cmake/Modules/GNUInstallDirs.cmakeand be able to find it viainclude(GNUInstallDirs)But can't find
/usr/share/cmake/Modules/PackageProject.cmakeviainclude(PackageProject). Weird.So, I've used
find_packageway: install the script to/usr/share/cmake/PackageProject/PackageProjectConfig.cmaketo be able to find it viafind_package(PackageProject). Theoretically speaking, even when PackageProject.cmake is added via CPM, it would work in both next cases:CPM_DOWNLOAD_ALL=1and in case ofCPM_LOCAL_PACKAGES_ONLY=1.I guess it's a win-win.
Cons
Pros
find_package(PackageProject.cmake)which is almost compatible with popular use via CPMadd_subdirectoryor downloading via CPM/FetchContent.CPMAddPackage(PackageProject.cmake)wasVERSION xx.x.xand-DCPM_LOCAL_PACKAGES_ONLY=1, it will fail, because it will find it, but won't be able to get its version, since I can't putproject(PackageProject.cmake VERSION xx.x.x)in since then the PackageProject's script itself will fail. ( was solved via renaming local variables in the PackageProject's script and installingPackageProject.cmakeConfigVersion.cmakeasidePackageProject.cmakeConfig.cmake)Ping @TheLartians