-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AsTypeDescription impl for human_repr types #170
Conversation
fa8c81f
to
7986523
Compare
I somehow got things a bit wrong... the I requested this functionality here: rsalmei/human-repr#4 But before this is implemented, we can postpone this PR I think. |
Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
7986523
to
849a465
Compare
human_repr got the |
What happens if you put I would accept the PR if it can be shown that:
|
Yeah now that I look at the code of the crate, they even implemented serde compatibility not as I intended. 😞 I think we can close this issue, as depending on the |
Hi @TheNeikos,
Of course in a configuration system precision is mandatory, rest assured I'm thinking about this. Anyway, the issue @matthiasbeyer opened there on my crate is opened, so I expect this could be reopened too. |
Heya @rsalmei thanks for the notice. I appreciate the heads up, and I am definitely interested in integrating it with the changes you've suggested. WRT to the units, you could maybe specify it as |
Closes #169