Chore: Remove Warnings

Because: * We were getting quite a few warnings about adding new cops to our Rubocop.yml file and the warning list grew everytime we bumped Rubocop. This commit: * Enables all new cops to get rid of the warnings now and in the future.
TheOdinProject · Apr 15, 2021 · 243438b · 243438b
1 parent 80fd2ab
commit 243438b
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 12 deletions.
diff --git a/.rspec b/.rspec
@@ -1,2 +1,2 @@
 --color
---require spec_helper
+--require rails_helper
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -12,8 +12,7 @@ AllCops:
     - 'bin/*'
     - 'node_modules/**/*'
     - db/schema.rb
-
-
+  NewCops: enable
 
 Layout/LineLength:
   Max: 120

diff --git a/app/models/user.rb b/app/models/user.rb
@@ -42,7 +42,7 @@ def active_for_authentication?
   end
 
   def inactive_message
-    !banned? ? super : :banned
+    banned? ? :banned : super
   end
 
   def dismissed_flags

diff --git a/app/services/lesson_duration.rb b/app/services/lesson_duration.rb
@@ -18,7 +18,7 @@ def title
 
   # rubocop:disable Style/RescueModifier
   def average_duration
-    durations.reduce(0) { |sum, duration| sum + duration } / durations.size rescue 0
+    durations.sum / durations.size rescue 0
   end
   # rubocop:enable Style/RescueModifier
 

diff --git a/spec/models/ability_spec.rb b/spec/models/ability_spec.rb
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb