fix(ci): remove charabia from Node package

TheOpenDictionary · Jun 17, 2024 · cf02d0c · cf02d0c
1 parent e42b92e
commit cf02d0c
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 56 deletions.
diff --git a/.github/workflows/napi.yml b/.github/workflows/napi.yml
@@ -22,60 +22,60 @@ jobs:
       fail-fast: false
       matrix:
         settings:
-          - host: macos-latest
-            target: x86_64-apple-darwin
-            build: pnpm build
-          - host: windows-latest
-            build: pnpm build
-            target: x86_64-pc-windows-msvc
-          - host: windows-latest
-            build: |
-              pnpm build --target i686-pc-windows-msvc
-              pnpm test
-            target: i686-pc-windows-msvc
-          - host: ubuntu-latest
-            target: x86_64-unknown-linux-gnu
-            docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian
-            build: pnpm build --target x86_64-unknown-linux-gnu
-          - host: ubuntu-latest
-            target: x86_64-unknown-linux-musl
-            docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
-            build: pnpm build
-          - host: macos-latest
-            target: aarch64-apple-darwin
-            build: pnpm build --target aarch64-apple-darwin
-          - host: ubuntu-latest
-            target: aarch64-unknown-linux-gnu
-            docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian-aarch64
-            build: pnpm build --target aarch64-unknown-linux-gnu
+          # - host: macos-latest
+          #   target: x86_64-apple-darwin
+          #   build: pnpm build
+          # - host: windows-latest
+          #   build: pnpm build
+          #   target: x86_64-pc-windows-msvc
+          # - host: windows-latest
+          #   build: |
+          #     pnpm build --target i686-pc-windows-msvc
+          #     pnpm test
+          #   target: i686-pc-windows-msvc
+          # - host: ubuntu-latest
+          #   target: x86_64-unknown-linux-gnu
+          #   docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian
+          #   build: pnpm build --target x86_64-unknown-linux-gnu
+          # - host: ubuntu-latest
+          #   target: x86_64-unknown-linux-musl
+          #   docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
+          #   build: pnpm build
+          # - host: macos-latest
+          #   target: aarch64-apple-darwin
+          #   build: pnpm build --target aarch64-apple-darwin
+          # - host: ubuntu-latest
+          #   target: aarch64-unknown-linux-gnu
+          #   docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-debian-aarch64
+          #   build: pnpm build --target aarch64-unknown-linux-gnu
           - host: ubuntu-latest
             target: armv7-unknown-linux-gnueabihf
             setup: |
               sudo apt-get update
               sudo apt-get install gcc-arm-linux-gnueabihf -y
             build: pnpm build --target armv7-unknown-linux-gnueabihf
-          - host: ubuntu-latest
-            target: aarch64-linux-android
-            build: pnpm build --target aarch64-linux-android
-          - host: ubuntu-latest
-            target: armv7-linux-androideabi
-            build: pnpm build --target armv7-linux-androideabi
-          - host: ubuntu-latest
-            target: aarch64-unknown-linux-musl
-            docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
-            build: |-
-              set -e &&
-              rustup target add aarch64-unknown-linux-musl &&
-              pnpm build --target aarch64-unknown-linux-musl
-          - host: windows-latest
-            target: aarch64-pc-windows-msvc
-            build: pnpm build --target aarch64-pc-windows-msvc
-          - host: ubuntu-latest
-            target: riscv64gc-unknown-linux-gnu
-            setup: |
-              sudo apt-get update
-              sudo apt-get install gcc-riscv64-linux-gnu -y
-            build: pnpm build --target riscv64gc-unknown-linux-gnu
+          # - host: ubuntu-latest
+          #   target: aarch64-linux-android
+          #   build: pnpm build --target aarch64-linux-android
+          # - host: ubuntu-latest
+          #   target: armv7-linux-androideabi
+          #   build: pnpm build --target armv7-linux-androideabi
+          # - host: ubuntu-latest
+          #   target: aarch64-unknown-linux-musl
+          #   docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
+          #   build: |-
+          #     set -e &&
+          #     rustup target add aarch64-unknown-linux-musl &&
+          #     pnpm build --target aarch64-unknown-linux-musl
+          # - host: windows-latest
+          #   target: aarch64-pc-windows-msvc
+          #   build: pnpm build --target aarch64-pc-windows-msvc
+          # - host: ubuntu-latest
+          #   target: riscv64gc-unknown-linux-gnu
+          #   setup: |
+          #     sudo apt-get update
+          #     sudo apt-get install gcc-riscv64-linux-gnu -y
+          #   build: pnpm build --target riscv64gc-unknown-linux-gnu
     name: stable - ${{ matrix.settings.target }} - node@20
     runs-on: ${{ matrix.settings.host }}
     steps:

diff --git a/lib/src/search/constants.rs b/lib/src/search/constants.rs
@@ -9,7 +9,6 @@ use tantivy::tokenizer::{LowerCaser, RemoveLongFilter, SimpleTokenizer};
 
 pub const CUSTOM_TOKENIZER: &str = "CUSTOM_TOKENIZER";
 
-#[cfg(feature = "charabia")]
 pub const DEFAULT_TOKENIZER: Lazy<TextAnalyzer> = Lazy::new(|| {
     #[cfg(not(feature = "charabia"))]
     return TextAnalyzer::builder(SimpleTokenizer::default())

diff --git a/node/Cargo.toml b/node/Cargo.toml
@@ -11,13 +11,7 @@ merge = "0.1.0"
 # Default enable napi4 feature, see https://nodejs.org/api/n-api.html#node-api-version-matrix
 napi = { version = "2.12.2", default-features = false, features = ["napi4"] }
 napi-derive = "2.12.2"
-odict = { path = "../lib", features = [
-  "config",
-  "charabia",
-  "sql",
-  "search",
-  "json",
-] }
+odict = { path = "../lib", features = ["config", "sql", "search", "json"] }
 once_cell = "1.19.0"
 
 [build-dependencies]