Make connection handling more robust #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderl78
reviewed
Jun 17, 2024
|
Ok, since 3 days no connection error. Perfekt. Thank you! |
|
@anderl78 Good to know, thank you for testing! I am not too experienced with Python programming so this was a bit of trial-and-error and I'm not sure if it is actually a valid approach, but it did improve the situation so it can't be completely wrong. |
|
@skrue: would be great if you could look here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solved #25 for me. Seems that
writercould not successfully be closed after aConnectionResetError. Now an exception is thrown andself._readerandself._writerare set toNone. This way the next attempt to open the connection succeeds.