Skip to content

refactor: Add override/final keywords to virtual functions with VC6 compatibility #5992

refactor: Add override/final keywords to virtual functions with VC6 compatibility

refactor: Add override/final keywords to virtual functions with VC6 compatibility #5992

Triggered via pull request February 24, 2026 23:55
Status Success
Total duration 18m 54s
Artifacts 20

ci.yml

on: pull_request
Detect File Changes
9s
Detect File Changes
Matrix: build-generalsmd-vc6
Matrix: build-generals
Matrix: build-generalsmd-win32
Matrix: replaycheck-generalsmd
Fit to window
Zoom out
Zoom in

Annotations

190 warnings
Build Generals / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / vc6-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / win32-vcpkg-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-vcpkg-debug+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-vcpkg-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWLib/thread.cpp#L19
'_WIN32_WINNT': macro redefinition
Build GeneralsMD / win32-vcpkg-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-vcpkg-debug+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-vcpkg-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-debug+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-profile+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-profile+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build GeneralsMD / win32+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWLib/thread.cpp#L19
'_WIN32_WINNT': macro redefinition
Build GeneralsMD / win32-vcpkg-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-vcpkg-profile+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-vcpkg-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-vcpkg-profile+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-vcpkg-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-debug+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-vcpkg+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-vcpkg+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-vcpkg+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-vcpkg+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning

Artifacts

Produced during runtime
Name Size Digest
Generals-vc6+t+e Expired
16.1 MB
sha256:2dfc131e5589c6559400a3db676b28343e7a037e1ca6dcc322bcd75cc51f399a
Generals-vc6-debug+t+e Expired
52 MB
sha256:f7c5fb5d648cfc4f6fc04b9d58834a3456bbd1d8e9dbe384dc1a57e057c728ba
Generals-vc6-profile+t+e Expired
16.1 MB
sha256:4db5f348b1e8d006a6f740e37681bade12b09423bda79194021ba5f2324e5ff4
Generals-win32+t+e Expired
85.5 MB
sha256:c76afb6d79728fd52a9d81eb1a3338f4c715a80a992f832fd6405fb55e025f9b
Generals-win32-debug+t+e Expired
204 MB
sha256:aea8f4833cbae962a0984efc6ea28117d2f3f68b2b3fa6e9072122535256d2b7
Generals-win32-profile+t+e Expired
85.4 MB
sha256:9e5534ce06828dedd543bb6055aff151214e0dd4366a0d8209ee534efcbe9ec4
Generals-win32-vcpkg+t+e Expired
85.4 MB
sha256:55ccdeda68e89309cf92ef0e3907afa78cfb59110a72855a03182f9f9a35b556
Generals-win32-vcpkg-debug+t+e Expired
203 MB
sha256:c49bfd5462f1991945d8be1d4dce7a15c9290acb26aa073eb40972a43265e552
Generals-win32-vcpkg-profile+t+e Expired
85.4 MB
sha256:0c2f7f0371ab7fb42d8b49b5dc61358b9a383ab7db5d916329af175c59951ce7
GeneralsMD-vc6+t+e Expired
17.1 MB
sha256:b40a52bde8fa9a1b369660e8bed33c1df979ecb2c8a56377534cedfeefec99a9
GeneralsMD-vc6-debug+t+e Expired
54.4 MB
sha256:8e8452313d51873babb86086bac1fa185c1f8c9599ff39bb213591f0f1e8e491
GeneralsMD-vc6-profile+t+e Expired
17.3 MB
sha256:0e0cf2b3eecfe1feb6a80bc9a0253d30696d2e8f143c28097d7f80ce015dc93d
GeneralsMD-vc6-releaselog+t+e Expired
30.4 MB
sha256:7112f4f82ec47d4c5d1e476652c1308652a694a010227e78e430f2953960ddb5
GeneralsMD-win32+t+e Expired
89.8 MB
sha256:3b1733b65b4dea7af4b5a9f43efa6c7497ca9ea77d893563d16c16720003915a
GeneralsMD-win32-debug+t+e Expired
212 MB
sha256:d0eae93db50018e57262998aa2e488256c368c7aa89c86f9c730f33cf0d9a209
GeneralsMD-win32-profile+t+e Expired
90.5 MB
sha256:be6905c75311dc77db381905fb9ce118dd4c422fd7167a48b4c18bd66249db7e
GeneralsMD-win32-vcpkg+t+e Expired
89.7 MB
sha256:06a4651a8ac30ff9f99eafab176c5bf3dda041180ab151a63ed6529269ab59d1
GeneralsMD-win32-vcpkg-debug+t+e Expired
212 MB
sha256:99a78adeaaaafd1bef9c56050d1c775adce2e5f5c5b33100a1892fefc87b7f6c
GeneralsMD-win32-vcpkg-profile+t+e Expired
90.3 MB
sha256:97345d658f87656ad9abe0de7fc1786cf13dae9c188e85648935bdce1b353128
Replay-Debug-Log-vc6-releaselog+t+e Expired
2.8 MB
sha256:5334716e6d834cb351f54d71ed9351d8a634ea3abe8e0f10f5005a820938a745