Use slot indices in the PlayerList for conversions from player index to slot index

[Caball009]

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/Common/RTS/PlayerList.cpp

Lines 500 to 508 in e378776

	Int PlayerList::getSlotIndex(Int playerIndex) const
	{
	if (playerIndex >= 0 && playerIndex < ARRAY_SIZE(m_slotIndices))
	{
	return m_slotIndices[playerIndex];
	}
	return -1;
	}

It should be possible to replace any code that does a conversion from player index to slot index with a call to PlayerList::getSlotIndex.

Incomplete list:

GameLogic::onLogicCrc

// "player%d":
ControlBar::populateObserverList
ConnectionManager::processChat
GameSpyStagingRoom::generateGameSpyGameResultsPacket
GameSpyStagingRoom::generateLadderGameResultsPacket
NetGameCommandMsg::constructGameMessage
Network::processDestroyPlayerCommand
RecorderClass::handleCRCMessage
PopulateInGameDiplomacyPopup
ToggleInGameChat
grabMultiPlayerInfo
InGameUI::drawPlayerInfoList
VictoryConditions::update
GameLogic::tryStartNewGame

[CryoTheRenegade]

I traced the remaining usages and found that the issue list mixes two conversion directions.

These are the only functions doing player index → slot index, so they can directly use PlayerList::getSlotIndex:

• GameLogic::onLogicCrc
• RecorderClass::handleCRCMessage
• VictoryConditions::update

The other listed functions start with a slot index and use "player%d" to find the corresponding Player. getSlotIndex cannot directly replace those reverse lookups.

Is the intended scope:

1. Only replace the three player → slot conversions with getSlotIndex; or
2. Also remove all slot → Player name lookups?

If the reverse lookups are included, should a reverse accessor such as PlayerList::getPlayerFromSlotIndex be created, or should we restructure those callers to iterate over the players and use getSlotIndex while preserving slot order?

I also found one additional reverse-lookup function not listed in the issue:

• GameSpyGameInfo::generateGameResultsPacket in both Generals and Zero Hour

It currently appears to have no call sites.