Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the particle effect for destroyed GLA Demo units #2311

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xezon
Copy link
Collaborator

@xezon xezon commented Aug 29, 2023

This change improves the particle effect for destroyed GLA Demo units. It now looks more similar to the regular Demo Suicide explosion, but with slightly smaller effects and without the explosion pillars.

shot_20230830_193613_3

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Art Is art related GLA Affects GLA faction labels Aug 29, 2023
@xezon xezon added the Patch104p Is specific to this project label Aug 30, 2023
@xezon
Copy link
Collaborator Author

xezon commented Aug 30, 2023

Image added. Documentation added. Looks good.

@commy2
Copy link
Collaborator

commy2 commented Aug 30, 2023

I want to try this first. The difference should be very noticable, since it does vastly different amounts of damage. 1.04 already is not very clear about this.

@xezon
Copy link
Collaborator Author

xezon commented Aug 30, 2023

They are distinct, also thanks to the diagonal line lol.

shot_20230830_200223_11

@commy2
Copy link
Collaborator

commy2 commented Aug 30, 2023

Yea, glow helps. Right one looks kind of big though. It does pathetic damage, so it really should just be a puff. The donut adds to the size and probably too much.

@xezon
Copy link
Collaborator Author

xezon commented Aug 30, 2023

It does not deal much damage, but it has huge damage radius. Bigger than suicide radius. Also keep in mind it needs to fit on vehicles. If it is too small, it will look unfitting.

I made a bit smaller now. Check.

@commy2 commy2 self-assigned this Aug 30, 2023
@commy2
Copy link
Collaborator

commy2 commented Aug 30, 2023

will do

@xezon
Copy link
Collaborator Author

xezon commented Jun 8, 2024

commy2

Re visuals: I think the donut could be smaller. I mean, same radius obv, but smaller wall thickness. Or maybe the radius could be decreased if it is also decided that the secondary damage radius should be 50 instead of 70.

xezon

We can reduce the radius to match or undercut suicide radius yes. Does not make sense that it is larger than suicide.

Edit:

@Float1ngFree
Copy link

Float1ngFree commented Jun 14, 2024

I've noticed that there's a continuous effects performance degradation the longer the game goes vs demo. Some visual & transition effects stop displaying the more demo units you kill & the more explosion they produce. I've tried playing with ParticleSystems Priority - changing from CRITICAL & WEAPON_EXPLOSION to DEATH_EXPLOSION but that didn't solve the issue.

Seems like effects are accumulating and prevent other effects from displaying fully. Similar to when you have too many firestorms simultaneously.

@xezon
Copy link
Collaborator Author

xezon commented Jun 14, 2024

Can you try to figure out which particle system is causing it? It needs its own bug report. Likewise we know that DisabledEffectBinaryShower0 is causing problems (#1739).

@Float1ngFree
Copy link

Can you try to figure out which particle system is causing it? It needs its own bug report. Likewise we know that DisabledEffectBinaryShower0 is causing problems (#1739).

I've tried switching back to WeaponFX_DemoSuicideDynamitePackDetonationPlusFire but the result is the same.
Commented out ExplosionSmall and DemoExplosionSmokeLite -- a bit better but still accumulates.
Set SystemLifetime for these new small ParticleSystems similar to WeaponFX_DemoSuicideDynamitePackDetonationPlusFire but no difference.

I'm sorry, I don't have much experience dealing with ParticleSystem items... You could try his on your side, just killing Demo AI units at his base (after demo upgrade) and observe how effects seem to stuck more and more...

BTW, in #1519 you've turned questionable ParticleSystem into green for debugging -- can you please share how that could be done? I want to debug this as well and check out couple more effects I have my doubts about.

@xezon
Copy link
Collaborator Author

xezon commented Jun 14, 2024

Is this performance bug Patch specific or in Original game?

@Float1ngFree
Copy link

Is this performance bug Patch specific or in Original game?

Seems to be Patch, original plays all animations no matter how many units/buildings you kill in at demo base...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Art Is art related GLA Affects GLA faction Minor Severity: Minor < Major < Critical < Blocker Patch104p Is specific to this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants