-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the particle effect for destroyed GLA Demo units #2311
base: main
Are you sure you want to change the base?
Conversation
772a3ae
to
f29e9d9
Compare
Image added. Documentation added. Looks good. |
f29e9d9
to
3c03b2d
Compare
I want to try this first. The difference should be very noticable, since it does vastly different amounts of damage. 1.04 already is not very clear about this. |
Yea, glow helps. Right one looks kind of big though. It does pathetic damage, so it really should just be a puff. The donut adds to the size and probably too much. |
It does not deal much damage, but it has huge damage radius. Bigger than suicide radius. Also keep in mind it needs to fit on vehicles. If it is too small, it will look unfitting. I made a bit smaller now. Check. |
will do |
commy2
xezon
Edit: |
I've noticed that there's a continuous effects performance degradation the longer the game goes vs demo. Some visual & transition effects stop displaying the more demo units you kill & the more explosion they produce. I've tried playing with ParticleSystems Seems like effects are accumulating and prevent other effects from displaying fully. Similar to when you have too many firestorms simultaneously. |
Can you try to figure out which particle system is causing it? It needs its own bug report. Likewise we know that |
I've tried switching back to I'm sorry, I don't have much experience dealing with ParticleSystem items... You could try his on your side, just killing Demo AI units at his base (after demo upgrade) and observe how effects seem to stuck more and more... BTW, in #1519 you've turned questionable ParticleSystem into green for debugging -- can you please share how that could be done? I want to debug this as well and check out couple more effects I have my doubts about. |
Is this performance bug Patch specific or in Original game? |
Seems to be Patch, original plays all animations no matter how many units/buildings you kill in at demo base... |
This change improves the particle effect for destroyed GLA Demo units. It now looks more similar to the regular Demo Suicide explosion, but with slightly smaller effects and without the explosion pillars.