bugfix: GLA Demo Technical no longer has to recentre its turret to suicide - #159
Merged
Stubbjax merged 1 commit intoAug 2, 2026
Conversation
Stubbjax
added
Bug
|
Is "centre" the correct word? |
|
Is not linked to TheSuperHackers/GeneralsGamePatch#164 in Migration Project. |
xezon
reviewed
Jul 24, 2026
| MaxIdleScanInterval = 10000 ; in milliseconds | ||
| MinIdleScanAngle = 30.0 ; in degrees off the natural turret angle | ||
| MaxIdleScanAngle = 60.0 ; in degrees off the natural turret angle | ||
| ControlledWeaponSlots = PRIMARY SECONDARY TERTIARY |
Contributor
Author
There was a problem hiding this comment.
It doesn't technically need to control the SECONDARY slot either. In fact none of the Technical variants need anything other than the PRIMARY slot.
It's possible the original developers mistakenly thought each salvage weapon required a different slot, or the weapons were switchable at some point during development. It's most likely a copy/paste error.
Should I streamline this here? It might make more sense to remove unnecessary ControlledWeaponSlots across all units as a standalone change.
Stubbjax
force-pushed
the
fix-technical-suicide-turret-dependency
branch
from
July 26, 2026 03:17
3450d53 to
cbf637a
Compare
Stubbjax
force-pushed
the
fix-technical-suicide-turret-dependency
branch
from
July 26, 2026 03:17
cbf637a to
39d4995
Compare
Stubbjax
changed the title
xezon
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change fixes an issue where the GLA Demo Technical has to centre its turret in order to detonate from a suicide command.
When ordering the Technical to suicide, the turret has to realign to face directly forward before the vehicle explodes. It takes a maximum of 0.75 seconds before the Technical explodes in case it was just firing at something directly behind it. This is not an issue with any other unit.
Before
BEFORE.mp4
After
AFTER.mp4