FreeRTOS downlink fix #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcserved
added
bug
|
@marnixcro Please check if we can do anything about this? |
|
I'll close this PR, and wait for issue #203 to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR increases the window of the RX retrieval. Additionally it removes the forced ADR sequence and fixes some documentation. Closes #201 #187.
Changes:
See the graph here:
Here a picture of the events (compared to the picture in issue #187)
Noticeable from both is that the retrieval times are now within the basic_lorawan application's retrieval window, but also extend far beyond this. So the power consumption is increased by this. I choose 200 specifically as it would be slightly before the 5s mark.
Notes for Reviewers:
Downlinks seem to be better, although not always perfect for me, although this happens with basic_lorawan as well so this can be due to the setup/antenna performance