Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeRTOS downlink fix #202

Closed
wants to merge 1 commit into from
Closed

FreeRTOS downlink fix #202

wants to merge 1 commit into from

Conversation

mcserved
Copy link
Contributor

@mcserved mcserved commented Jul 1, 2021

Summary:

This PR increases the window of the RX retrieval. Additionally it removes the forced ADR sequence and fixes some documentation. Closes #201 #187.

Changes:

  • Increase the RX error by 150, allowing the retrieval to start just below 5s.
  • Remove the ADR enable sequence at the start, as this was already handled with a variable.
  • Improve some documentation.

See the graph here:

basic_lorawan freertos_lorawan (new) freertos
5s14ms 5s129ms 4s980ms
218ms 271ms 531ms
781ms 754ms 492ms
218ms 271ms 531ms

Here a picture of the events (compared to the picture in issue #187)
image

Noticeable from both is that the retrieval times are now within the basic_lorawan application's retrieval window, but also extend far beyond this. So the power consumption is increased by this. I choose 200 specifically as it would be slightly before the 5s mark.

Notes for Reviewers:

Downlinks seem to be better, although not always perfect for me, although this happens with basic_lorawan as well so this can be due to the setup/antenna performance

@mcserved mcserved added bug Something isn't working Firmware Anything related to code and SW on the HW labels Jul 1, 2021
@mcserved mcserved added this to the 2021 Q2 milestone Jul 1, 2021
@mcserved mcserved requested a review from elsalahy July 1, 2021 08:07
@mcserved mcserved self-assigned this Jul 1, 2021
@mcserved mcserved linked an issue Jul 1, 2021 that may be closed by this pull request
@elsalahy
Copy link
Contributor

elsalahy commented Jul 1, 2021

@marnixcro
I think this solves an issue and creates a new one as increasing the Rx window from 200 to 500 is not a welcomed addition from the POV of the LoRaWAN specifications or power consumption.

Please check if we can do anything about this?
Otherwise
Please open a backlog/technical debt issue to reduce the lorawanConfigRX_MAX_TIMING_ERROR and to fix the underlying OS time drift.

@mcserved
Copy link
Contributor Author

mcserved commented Jul 5, 2021

I'll close this PR, and wait for issue #203 to be fixed.

@mcserved mcserved closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Firmware Anything related to code and SW on the HW
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FreeRTOS LoRaWAN ADR not configurable Fix freertos_lorawan downlink
2 participants