Feature/AzureRtos #177
Feature/AzureRtos #177
Conversation
|
@johanstokking feel free to give it a quick look, but this is mainly just a notification for you to be aware of the new support. |
There was a problem hiding this comment.
I have a few minor things you might want to look at, but overall the application works (I even got it to replace the led with a buzzer) and there were no real deal breakers I could find. The power consumption of the base app is kinda awful (20mA all the time), but I have hope that the lorawan version will improve upon this :)
Software/app/basic_azurertos/main.c
Outdated
| void thread_1_entry(ULONG thread_input); | ||
| void thread_2_entry(ULONG thread_input); | ||
|
|
||
| int main(int argc, char **argv) |
There was a problem hiding this comment.
Is there a reason this particular app uses argc/argv instead of void like all the other apps?
There was a problem hiding this comment.
No, it's inherited from some demo code, good catch
Software/app/basic_azurertos/main.c
Outdated
| tx_kernel_enter(); | ||
| } | ||
|
|
||
| /* Define what the initial system looks like */ |
There was a problem hiding this comment.
Extremely nitpicky, but this comment (and some others in this file) end with two spaces instead of one before closing
| /* The length of time the LED will remain on for. It is on just long enough | ||
| to be able to see with the human eye so as not to distort the power readings too | ||
| much. */ | ||
| #define APP_LED_TOGGLE_DELAY (20) |
There was a problem hiding this comment.
Extremely nitpicky, but basic_freertos has essentially the same config variable but only it's called LED_TOGGLE_DELAY, so maybe for consistency we could change this or the other.
There was a problem hiding this comment.
Fixed this but in the future all app conf will have an APP prefix
| } | ||
| else | ||
| { | ||
| break; |
There was a problem hiding this comment.
Is it wise to break out of the while loop if the queue sending fails? What will happen when a user accidentally configures it wrong?
There was a problem hiding this comment.
Yes this is intentional, because if there is bad configuration, the app should not function
elsalahy
force-pushed
the
feature/azure_rtos
branch
from
4e28d2d
to
c082041
Compare
elsalahy
force-pushed
the
feature/azure_rtos
branch
from
c082041
to
7277e8f
Compare
lib: Adjust system clock t0 48Mhz doc: Fix some spelling mistakes in lib description
app: Improve basic_azurertos app comments doc: Add basic_azurertos config link dev: Add basic_azurertos STM32CubeIDE support
|
@marnixcro I reduced the number of commits and did some minor docs improvements, please give it an approve when you can. |
elsalahy
force-pushed
the
feature/azure_rtos
branch
from
7277e8f
to
864e9cd
Compare
Summary:
This PR adds support for the awesome AzureRTOS (threadx)
Closes #165
This paves the way for the LoRaWAN example in #166
Changes:
basic_azurertosapplicationNotes for Reviewers:
...
Release Notes: (optional)
Add AzureRTOS support