Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update helm chart ingress controller setup info #1386

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vlasebian
Copy link
Contributor

@vlasebian vlasebian commented Oct 23, 2024

Summary

References issue #44 in lorawan-stack-k8s repo.

Screenshots

Screenshot 2024-10-23 at 15 48 45 Screenshot 2024-10-23 at 15 48 54 Screenshot 2024-10-23 at 15 49 12

Changes

  • Update step in prerequisites section of the k8s generic TTS hosting instructions.
  • Update affected yaml configuration

Notes for Reviewers

  • Is there more info need for the ingress controller step or is it enough?

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Run Locally: Verified that the docs build using make server, posted screenshots, verified external links. Test with HUGO_PARAMS_SEARCH_ENABLED=true if style changes will affect the search bar.
  • New Features Marked: Documentation for new features is marked using the new-in-version shortcode, according to the guidelines in CONTRIBUTING.
  • Style Guidelines: Documentation obeys style guidelines in CONTRIBUTING.
  • Commits: Commit messages follow guidelines in CONTRIBUTING, there are no fixup commits left.

@vlasebian vlasebian self-assigned this Oct 23, 2024
@vlasebian vlasebian requested a review from KrishnaIyer October 23, 2024 15:22
Copy link
Contributor

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Can you add the Traefik and Nginx examples?
You can create an sample-ingress-controllers doc and add the examples of Traefik and Nginx there.

@KrishnaIyer KrishnaIyer added this to the Oct 2024 milestone Oct 24, 2024
@vlasebian
Copy link
Contributor Author

This looks good. Can you add the Traefik and Nginx examples? You can create an sample-ingress-controllers doc and add the examples of Traefik and Nginx there.

Done.

@vlasebian vlasebian requested a review from KrishnaIyer October 28, 2024 09:55
Copy link
Contributor

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Let's get back here once https://github.com/TheThingsIndustries/lorawan-stack-k8s/pull/44 is reviewed and merged in case there are updates from there that need to be adapted here.

@KrishnaIyer KrishnaIyer modified the milestones: Oct 2024, Nov 2024 Oct 28, 2024
@KrishnaIyer KrishnaIyer modified the milestones: Nov 2024, Dec 2024 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants