Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Backend Interfaces 1.1 support, authenticate with NSID #5149

Merged
merged 12 commits into from
Jan 31, 2022

Conversation

johanstokking
Copy link
Member

Summary

Groundwork for #4847

Changes

  • Add proper LoRaWAN Backend Interfaces 1.1 support for interacting with a Join Server by using the mandatory SenderNSID (EUI64) from config
  • Support HTTP basic authentication with Join Servers
  • Remove obsolete DNS lookup for JS
  • Simplify pkg/interop client implementation and removed generated YAML in testing

Testing

CI and local integration testing with new The Things Join Server

Regressions

None expected

Checklist

This is a draft, still needs documentation and changelog

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking added c/network server This is related to the Network Server c/shared This is shared between components compat/config This could affect Configuration compatibility labels Jan 26, 2022
@johanstokking johanstokking added this to the v3.18.0 milestone Jan 26, 2022
@johanstokking johanstokking self-assigned this Jan 26, 2022
@github-actions github-actions bot added c/identity server This is related to the Identity Server c/join server This is related to the Join Server labels Jan 26, 2022
@johanstokking johanstokking changed the title Feature/js interop nsid Fix Backend Interfaces 1.1 support, authenticate with NSID Jan 26, 2022
@johanstokking johanstokking added the technical debt Not necessarily broken, but could be done better/cleaner label Jan 26, 2022
@johanstokking johanstokking marked this pull request as ready for review January 27, 2022 08:07
@johanstokking johanstokking changed the base branch from v3.17 to v3.18 January 27, 2022 08:07
@johanstokking
Copy link
Member Author

@adriansmares no functional changes since your last review.

I'll wait with merging until the changelog in v3.18 is up to date.

Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks pretty good. I'm testing now so I'll get back if there's anything.

Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also integration tests successful.

@johanstokking johanstokking force-pushed the feature/js-interop-nsid branch from 9aea730 to a04e1f8 Compare January 31, 2022 15:51
@johanstokking johanstokking merged commit 46457e7 into v3.18 Jan 31, 2022
@johanstokking johanstokking deleted the feature/js-interop-nsid branch January 31, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/identity server This is related to the Identity Server c/join server This is related to the Join Server c/network server This is related to the Network Server c/shared This is shared between components compat/config This could affect Configuration compatibility technical debt Not necessarily broken, but could be done better/cleaner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants