-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Backend Interfaces 1.1 support, authenticate with NSID #5149
Conversation
@adriansmares no functional changes since your last review. I'll wait with merging until the changelog in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks pretty good. I'm testing now so I'll get back if there's anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also integration tests successful.
9aea730
to
a04e1f8
Compare
Summary
Groundwork for #4847
Changes
pkg/interop
client implementation and removed generated YAML in testingTesting
CI and local integration testing with new The Things Join Server
Regressions
None expected
Checklist
This is a draft, still needs documentation and changelog
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.