-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetch End Device Template by numeric IDs #5323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KrishnaIyer
commented
Mar 22, 2022
KrishnaIyer
force-pushed
the
feature/4842-device-info
branch
from
March 22, 2022 08:31
88876d4
to
147a3d7
Compare
KrishnaIyer
requested review from
adriansmares,
johanstokking,
htdvisser and
pgalic96
as code owners
March 22, 2022 08:35
htdvisser
reviewed
Mar 22, 2022
5 tasks
KrishnaIyer
force-pushed
the
feature/4842-device-info
branch
from
March 23, 2022 09:07
147a3d7
to
ca195a5
Compare
htdvisser
approved these changes
Mar 28, 2022
johanstokking
approved these changes
Mar 29, 2022
KrishnaIyer
force-pushed
the
feature/4842-device-info
branch
from
March 30, 2022 08:53
ca195a5
to
bcb390f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4842
Changes
GetTemplate
RPC to allow numeric IDs and get them.no-op
implementation.Testing
UT + local
Regressions
GetTemplate
function (which loads the template on the console) is tested and works as expected.Notes for Reviewers
vendorProfileID
. This field is either not present or filled with the same value for all devices for a brand. Until now this wasn't necessary, but for customers to use this PR properly, those need to be adjusted. cc @Jaime-TrinidadChecklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.