Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch End Device Template by numeric IDs #5323

Merged
merged 18 commits into from
Mar 30, 2022
Merged

Conversation

KrishnaIyer
Copy link
Member

@KrishnaIyer KrishnaIyer commented Mar 21, 2022

Summary

Closes #4842

Changes

  • Create a new index in bleve for the profiles.
  • Extend the GetTemplate RPC to allow numeric IDs and get them.
  • Update tests
  • Remove the unused no-op implementation.

Testing

UT + local

Regressions
  • The current GetTemplate function (which loads the template on the console) is tested and works as expected.

Notes for Reviewers

  1. Afaik, none of the device profiles in the repository have a correct vendorProfileID. This field is either not present or filled with the same value for all devices for a brand. Until now this wasn't necessary, but for customers to use this PR properly, those need to be adjusted. cc @Jaime-Trinidad

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@KrishnaIyer KrishnaIyer added this to the v3.19.0 milestone Mar 21, 2022
@KrishnaIyer KrishnaIyer self-assigned this Mar 21, 2022
@github-actions github-actions bot added the compat/api This could affect API compatibility label Mar 21, 2022
@KrishnaIyer KrishnaIyer force-pushed the feature/4842-device-info branch from 88876d4 to 147a3d7 Compare March 22, 2022 08:31
@KrishnaIyer KrishnaIyer marked this pull request as ready for review March 22, 2022 08:35
api/devicerepository.proto Outdated Show resolved Hide resolved
api/devicerepository.proto Outdated Show resolved Hide resolved
@KrishnaIyer KrishnaIyer force-pushed the feature/4842-device-info branch from 147a3d7 to ca195a5 Compare March 23, 2022 09:07
@KrishnaIyer KrishnaIyer requested a review from htdvisser March 23, 2022 09:08
@htdvisser htdvisser changed the base branch from v3.18 to v3.19 March 28, 2022 12:02
api/devicerepository.proto Outdated Show resolved Hide resolved
api/devicerepository.proto Outdated Show resolved Hide resolved
pkg/devicerepository/store/bleve/store.go Show resolved Hide resolved
@KrishnaIyer KrishnaIyer force-pushed the feature/4842-device-info branch from ca195a5 to bcb390f Compare March 30, 2022 08:53
@KrishnaIyer KrishnaIyer merged commit d168a51 into v3.19 Mar 30, 2022
@KrishnaIyer KrishnaIyer deleted the feature/4842-device-info branch March 30, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat/api This could affect API compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get device information by vendor ID and profile ID
4 participants