-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower stored MAC state data #5599
Conversation
ceb5541
to
b422407
Compare
786ad65
to
5fd271a
Compare
1d8ed7a
to
c842e66
Compare
15a059e
to
b8d1578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also be fine with keep using the original messages but define a field mask for storage.
Code quality wise I don't think it's necessary to declare all fields reserved with the original message's field name as they diverge. If it's just to make sure that our future selves don't add fields with the same numbers and old binary data gets unmarshaled and lead to corrupted data, we can just declare the reservations in short form.
I've minimised the Regarding the field mask - The field mask tooling does not support applying field masks to repeated fields - see TheThingsIndustries/protoc-gen-fieldmask#37 , and a lot of the dropped fields are in Offtopic: We probably should fix that before we add field masks to webhooks, since most of the filtering that I expect will be in the |
4f3c9de
to
02b89ea
Compare
Summary
Closes #5127
Changes
MACState
message, add minimized versions ofUplinkMessage
,DownlinkMessage
,Message
,TxSettings
andRxMetadata
UplinkMessage
/DownlinkMessage
are not accidentally used (i.e. using zero values as if they were intentional)AFCntDown
sanity checkTesting
Unit testing.
Regressions
The code that actually uses these fields is unchanged in this PR - if a field was skipped in the minimal representation, it would result in a compile error. The only error prone operation is the conversion between the normal message and the minimal message, which I've double checked and also covered via existing unit tests.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.