Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add claiming tests for end device onboarding #5775

Conversation

kschiffer
Copy link
Contributor

@kschiffer kschiffer commented Sep 6, 2022

Summary

This PR adds claiming tests for the new device onboarding flow.

References #4847

Changes

  • Add claim end-to-end tests
  • Update other DO tests with progressive insight
  • Apply some small fixes to DO related to the new tests

Testing

Yes.

Notes for Reviewers

I decided against splitting up the claim tests into device repository and manual type (in two files). Instead I used one test spec for both. I focused the tests on the claiming aspects to avoid too much repetition with the existing tests.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added c/console This is related to the Console ui/web This is related to a web interface tooling Development tooling labels Sep 6, 2022
@kschiffer kschiffer self-assigned this Sep 6, 2022
@kschiffer kschiffer requested a review from ryaplots as a code owner September 6, 2022 16:12
@github-actions github-actions bot removed tooling Development tooling c/console This is related to the Console labels Sep 6, 2022
@kschiffer kschiffer added c/console This is related to the Console tooling Development tooling labels Sep 7, 2022
Copy link
Contributor

@ryaplots ryaplots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kschiffer kschiffer force-pushed the feature/4847-device-onboarding-claiming-tests branch from ac11531 to dca0443 Compare September 7, 2022 18:47
@github-actions github-actions bot removed c/console This is related to the Console tooling Development tooling labels Sep 7, 2022
@kschiffer kschiffer merged commit 395aeed into feature/4847-device-onboarding Sep 7, 2022
@kschiffer kschiffer deleted the feature/4847-device-onboarding-claiming-tests branch September 7, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants