-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New device onboarding flow #5798
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Compton <[email protected]>
Co-authored-by: Darya Plotnytska <[email protected]>
Co-authored-by: Darya Plotnytska <[email protected]>
Co-authored-by: Darya Plotnytska <[email protected]> Co-authored-by: Michael Compton <[email protected]>
Co-authored-by: Darya Plotnytska <[email protected]> Co-authored-by: Michael Compton <[email protected]>
Co-authored-by: Darya Plotnytska <[email protected]> Co-authored-by: Michael Compton <[email protected]>
Co-authored-by: Darya Plotnytska <[email protected]> Co-authored-by: Michael Compton <[email protected]>
kschiffer
added
c/console
This is related to the Console
ui/web
This is related to a web interface
labels
Sep 12, 2022
ryaplots
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me
mjamescompton
approved these changes
Sep 13, 2022
github-actions
bot
added
dependencies
Pull requests that update a dependency file
and removed
c/console
This is related to the Console
labels
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #4847
Screenshots
Changes
Testing
There was a lot of testing involved in this both manually and using end-to-end test specifications
Regressions
This PR also removes the old device onboarding flow, but still integrates a lot of that former logic. We tried our best to test any possible flow but a change of this size is not unlikely to have some regressions. These regressions should be related to whether certain devices can be registered and/or how the registration will be fulfilled on the individual stack components.
Notes for Reviewers
In detail review should not be possible, since this PR only combines parts that have already been reviewed. I have not changed anything with regards to implementation, only reorganized commits, did some file renaming and added a changelog entry.
Please still do a small review to double-check whether there is anything odd.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.