Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New device onboarding flow #5798

Merged
merged 14 commits into from
Sep 13, 2022
Merged

New device onboarding flow #5798

merged 14 commits into from
Sep 13, 2022

Conversation

kschiffer
Copy link
Contributor

Summary

Closes #4847

image

Screenshots image
image
image
image
image

Changes

  • Adding the new integrated end device onboarding flow
    • Adding devices using the device repository
    • Adding devices manually
    • Claiming devices using the device repository
    • Claiming devices providing device type information manually
    • Scanning end device QR codes to provide device information
    • Choosing the right provisioning type (registration or claiming) based on the Join EUI
  • Adding and extending cypress end-to-end tests for device onboarding
  • Various related adjustments to other components

Testing

There was a lot of testing involved in this both manually and using end-to-end test specifications

Regressions

This PR also removes the old device onboarding flow, but still integrates a lot of that former logic. We tried our best to test any possible flow but a change of this size is not unlikely to have some regressions. These regressions should be related to whether certain devices can be registered and/or how the registration will be fulfilled on the individual stack components.

Notes for Reviewers

In detail review should not be possible, since this PR only combines parts that have already been reviewed. I have not changed anything with regards to implementation, only reorganized commits, did some file renaming and added a changelog entry.

Please still do a small review to double-check whether there is anything odd.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@kschiffer kschiffer added c/console This is related to the Console ui/web This is related to a web interface labels Sep 12, 2022
@kschiffer kschiffer added this to the v3.22.0 milestone Sep 12, 2022
@kschiffer kschiffer self-assigned this Sep 12, 2022
Copy link
Contributor

@ryaplots ryaplots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me

@kschiffer kschiffer merged commit 124c8a8 into v3.22 Sep 13, 2022
@kschiffer kschiffer deleted the feature/4847-device-onboarding branch September 13, 2022 14:46
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed c/console This is related to the Console labels Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

End device onboarding flow
3 participants