Simplify Packet Broker settings

[ryaplots]

Summary

Closes #3838

Changes

• Update packet broker main view
• Separate two forms
• Add radio button options
• Update e2e tests
• Remove gateway visibility

Testing

1. Open packet broker in the admin panel.
2. Select the first two options one at a time to make sure each one is successful.
3. Select custom configuration, go to the network tab and change a network config.
4. Reload the page see that the configuration you selected is the one shown.

Checklist

• Scope: The referenced issue is addressed, there are no unrelated changes.
• Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
• Documentation: Relevant documentation is added or updated.
• The steps/process to test this feature are clearly explained including testing for regressions.
• Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
• Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

[johanstokking]

I tested this locally and I have a few issues:

1. If you select sandbox, it creates a policy with NetID 000013 but not tenant ID ttn. It should be with tenant ID ttn explicitly because that is the community network.
2. When I go from the first radio button (forward traffic to all networks) and save, there's indeed a default routing policy created. However, the home network routing policy with 00013 is still there. I think all other policies should be deleted
3. When I go back to the second radio button (forward to sandbox) and click save, I get the error [0]

[0]

{
  "code": 3,
  "message": "type mismatch, parameter: net_id, error: strconv.ParseUint: parsing \"NaN\": invalid syntax"
}

[ryaplots]

I tested this locally and I have a few issues:

1. If you select sandbox, it creates a policy with NetID `000013` but not tenant ID `ttn`. It should be with tenant ID `ttn` explicitly because that is the community network.

2. When I go from the first radio button (forward traffic to all networks) and save, there's indeed a default routing policy created. However, the home network routing policy with `00013` is still there. I think all other policies should be deleted

3. When I go back to the second radio button (forward to sandbox) and click save, I get the error [0]

[0]

{
  "code": 3,
  "message": "type mismatch, parameter: net_id, error: strconv.ParseUint: parsing \"NaN\": invalid syntax"
}

1. When trying to create a policy with an explicit tenant id (this url: https://tti.staging1.cloud.thethings.industries/api/v3/pba/home-networks/policies/19/ttn) I get an error:

{
  "code": 10,
  "message": "error:unknown:unknown (bad reference)",
  "details": [
    {
      "@type": "type.googleapis.com/ttn.lorawan.v3.ErrorDetails",
      "message_format": "bad reference",
      "correlation_id": "fa423e90d1854199bb417f4497ffb3be",
      "code": 10
    }
  ]
}

I checked the staging networks list and it seems like The Things Network network does not have a tenant id. Also when updating its policy the request is sent to https://tti.staging1.cloud.thethings.industries/api/v3/pba/home-networks/policies/19, which is why I used the same net_id and did not indicate a tenant ID.

2. I will update this.

3. Also looking into fixing this.

@johanstokking

[kschiffer]

If you select sandbox, it creates a policy with NetID 000013 but not tenant ID ttn. It should be with tenant ID ttn explicitly because that is the community network.

TTN is not on a tenant, is it? It's a single-tenant network, or what am I missing?

[johanstokking]

If you select sandbox, it creates a policy with NetID 000013 but not tenant ID ttn. It should be with tenant ID ttn explicitly because that is the community network.

TTN is not on a tenant, is it? It's a single-tenant network, or what am I missing?

Yeah it actually is a tenant, but not on The Things Stack Cloud. The Things Stack Sandbox is a single tenant deployment that uses NetID 000013 and tenant ID ttn. For Packet Broker, there's no difference between ttn and TTSC tenants.

@ryaplots indeed the ttn tenant was missing on Packet Broker staging. It is there now.

[kschiffer]

The default gateway visibility configuration should not be deleted but moved to a separate tab next to "Routing configuration".

[kschiffer]

See this updated wireframe:

[ryaplots]

See this updated wireframe:

Where can I get the texts from the tooltips of the routing options? @kschiffer

[kschiffer]

Let's skip them for now.

[kschiffer]

We need to update the routing there in general a bit and make /routing-configuration an explicit routes, otherwise there is ambiguity in the active link selection. (Try selecting the network tab within routing configuration and notice that Routing configuration is not selected anymore.

I've taken a shot at this and added a fix commit.

[kschiffer]

Please do a final test of the new code before merging.

[johanstokking]

1. What I'm now missing is a way to reset the default routing policy. If you now have custom selected, you have an empty default routing policy, even if none is set. If you click Save, it saves an empty default routing policy. But as outlined in Simplify Packet Broker settings #6639 (comment), there is a difference between no default routing policy and an all-zero default routing policy.

2. If you have "Forward traffic to all networks registered in Packet Broker" selected (and saved) and then click Custom, it would be nice to have the default routing policy enabled and all-checked, because that's what the current state is.

[ryaplots]

1. What I'm now missing is a way to reset the default routing policy. If you now have custom selected, you have an empty default routing policy, even if none is set. If you click Save, it saves an empty default routing policy. But as outlined in Simplify Packet Broker settings #6639 (comment), there is a difference between no default routing policy and an all-zero default routing policy.

   2. If you have "Forward traffic to all networks registered in Packet Broker" selected (and saved) and then click Custom, it would be nice to have the default routing policy enabled and all-checked, because that's what the current state is.

I have taken this into account and added back the functionality. @johanstokking Please review.

[johanstokking]

Thanks, this now works as expected.