Skip to content

Fix application uplink queue test flake #6643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

adriansmares
Copy link
Contributor

@adriansmares adriansmares commented Oct 19, 2023

Summary

References https://github.com/TheThingsIndustries/lorawan-stack/pull/3890

This PR fixes this flake.

Changes

  • Insert the uplinks into the uplink queue before attempting to read them.
  • Append uplinks synchronously, instead of using a goroutine (which we are not waiting).

Testing

go test -v -count=500 -run=TestApplicationUplinkQueue
...
PASS
ok      go.thethings.network/lorawan-stack/v3/pkg/networkserver/redis   32.394s

No manual testing is required. This PR strictly treats a testing flake.

Regressions

N/A.

Notes for Reviewers

@cvetkovski98 please take a look.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • The steps/process to test this feature are clearly explained including testing for regressions.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@adriansmares adriansmares added this to the v3.28.1 milestone Oct 19, 2023
@adriansmares adriansmares self-assigned this Oct 19, 2023
@github-actions github-actions bot added c/network server This is related to the Network Server compat/db This could affect Database compatibility labels Oct 19, 2023
Copy link

@cvetkovski98 cvetkovski98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced the flake locally by running the tests with -count 10. The change fixes the problem.

@adriansmares adriansmares marked this pull request as ready for review October 19, 2023 12:35
@adriansmares adriansmares merged commit 3c9cf14 into v3.28 Oct 19, 2023
@adriansmares adriansmares deleted the fix/app-queue-flake branch October 19, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/network server This is related to the Network Server compat/db This could affect Database compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants