-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate whether the frequency plan is applicable to gateways #7235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halimi
changed the title
util: Add
Indicate whether the frequency plan is applicable to gateways
Aug 13, 2024
Gateways
field to the FrequencyPlan
halimi
commented
Aug 13, 2024
halimi
force-pushed
the
feature/filter-frequency-plans
branch
from
August 14, 2024 08:57
e6eb765
to
d690f6a
Compare
Today is the merge deadline but I won't have time to review this unfortunately. Moving the milestone. |
KrishnaIyer
reviewed
Aug 28, 2024
halimi
force-pushed
the
feature/filter-frequency-plans
branch
from
August 30, 2024 13:57
2097d13
to
b7a44d9
Compare
johanstokking
approved these changes
Sep 2, 2024
johanstokking
approved these changes
Sep 4, 2024
KrishnaIyer
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References: TheThingsNetwork/lorawan-frequency-plans#41
Extended the
FrequencyPlanDescription
struct withGateways
field to indicate that the frequency plan is relevant for a gateway.Added
GatewaysOnly
flag to theListFrequencyPlans
RPC to filter out non-gateway related plans.Changes
FrequencyPlanDescription
struct withGateways
field to indicate that the frequency plan is relevant for a gatewayGatewaysOnly
flag to theListFrequencyPlans
RPC to filter out non-gateway related plansgateways-only
flag to thelist-frequency-plans
CLI command to filter out non-gateway related plansTesting
Steps
gateways-only
flag on thelist-frequency-plans
CLI command to filter out non-gateway related frequency plansResults
gateways
filed istrue
Regressions
Notes for Reviewers
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.