add field-mask to dezem.yml #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - received_at | ||
| - up.uplink_message.decoded_payload | ||
| - up.uplink_message.rx_metadata | ||
| - up.uplink_message.settings.data_rate.modulation.lora.spreading_factor |
There was a problem hiding this comment.
I recommend receiving the full data rate. It is not unheard of that you may receive uplinks which are LoRa modulated at 500KHz or 250KHz, and LoRa is not the only modulation available in LoRaWAN.
There was a problem hiding this comment.
Thanks for the Input. You are right. I've discussed it with the team. For now, we want to keep the template as proposed in this PR as this is the use case that usually applies for us and we want to reduce the payload size.
And... it's just a template. If someone creates a Webhook based on the this template, the person can easily alter the field mask in the GUI.
adriansmares
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dezem.ymlChecklist
[ ] Documentation: Relevant documentation is added or updated.