feat!(ios): remove native dependency promises (#3631)

TheWidlarzGroup · Apr 4, 2024 · 10b100d · 10b100d
1 parent 2633f08
commit 10b100d
Show file tree

Hide file tree

Showing 15 changed files with 673 additions and 772 deletions.
diff --git a/docs/pages/index.md b/docs/pages/index.md
@@ -6,7 +6,8 @@
 ## Beta Information
 > ⚠️ **Version 6 Beta**: The following documentation may refer to features only available through the v6.0.0 alpha releases, [please see version 5.2.x](https://github.com/react-native-video/react-native-video/blob/v5.2.0/README.md) for the current documentation!
 
-Version 6.x recommends react-native >= 0.68.2.
+Version 6.x requires **react-native >= 0.68.2**
+> ⚠️ from **6.0.0-beta.8** requires also **iOS >= 13.0** (default in react-native 0.73)
 
 For older versions of react-native, [please use version 5.x](https://github.com/react-native-video/react-native-video/tree/v5.2.0).
 

diff --git a/docs/pages/installation.md b/docs/pages/installation.md
@@ -22,6 +22,7 @@ Then follow the instructions for your platform to link react-native-video into y
 ## iOS
 
 ### Standard Method
+Run `pod install` in the `ios` directory of your project.
 
 ### Enable custom feature in podfile file
 
@@ -155,16 +156,8 @@ Select RCTVideo-tvOS
 <summary>visionOS</summary>
 
 ## visionOS
-Add patch for `promises` pods to your pod files to make it work with `visionOS` target.
-> This patch is required only for `visionOS` target and will be removed in future.
-```diff
-+ pod 'PromisesSwift', :podspec => '../node_modules/react-native-video/ios/patches/PromisesSwift.podspec'
-+ pod 'PromisesObjC', :podspec => '../node_modules/react-native-video/ios/patches/PromisesObjC.podspec'
-```
-
-**Remember** to run `pod install` after adding this patch.
+Run `pod install` in the `visionos` directory of your project
 
-After this you can follow the same steps as for `iOS` target.
 </details>
 
 ## Examples

diff --git a/examples/basic/ios/Podfile.lock b/examples/basic/ios/Podfile.lock
@@ -7,9 +7,6 @@ PODS:
   - hermes-engine (0.74.0-rc.4):
     - hermes-engine/Pre-built (= 0.74.0-rc.4)
   - hermes-engine/Pre-built (0.74.0-rc.4)
-  - PromisesObjC (2.4.0)
-  - PromisesSwift (2.4.0):
-    - PromisesObjC (= 2.4.0)
   - RCT-Folly (2024.01.01.00):
     - boost
     - DoubleConversion
@@ -942,7 +939,6 @@ PODS:
     - React-Core
     - react-native-video/Video (= 6.0.0-beta.6)
   - react-native-video/Video (6.0.0-beta.6):
-    - PromisesSwift
     - React-Core
   - React-nativeconfig (0.74.0-rc.4)
   - React-NativeModulesApple (0.74.0-rc.4):
@@ -1239,8 +1235,6 @@ DEPENDENCIES:
 
 SPEC REPOS:
   trunk:
-    - PromisesObjC
-    - PromisesSwift
     - SocketRocket
 
 EXTERNAL SOURCES:
@@ -1365,8 +1359,6 @@ SPEC CHECKSUMS:
   fmt: 4c2741a687cc09f0634a2e2c72a838b99f1ff120
   glog: c5d68082e772fa1c511173d6b30a9de2c05a69a2
   hermes-engine: dfdcadd89a22aa872ef552b07e415d88df68af55
-  PromisesObjC: f5707f49cb48b9636751c5b2e7d227e43fba9f47
-  PromisesSwift: 9d77319bbe72ebf6d872900551f7eeba9bce2851
   RCT-Folly: 045d6ecaa59d826c5736dfba0b2f4083ff8d79df
   RCTDeprecation: 1c5ab5895f9fc7e8ae9fcde04859f0d246283209
   RCTRequired: 79e2e81174db06336f470c49aea7603ff29817a7
@@ -1391,7 +1383,7 @@ SPEC CHECKSUMS:
   React-jsitracing: 50e3ea936a199a2a7fcab922f156507c97f0b88c
   React-logger: 6004e0cf41b7e9714ca26b1648e5d76fcfd638b5
   React-Mapbuffer: 9b163fa28e549d5f36f89a39a1145fcaf262d0d0
-  react-native-video: dc3118548cf8864a83f57df4345cf6c692402e8f
+  react-native-video: d340c162bf7974c2935fbeec0c5dea362f9dd74a
   React-nativeconfig: 3948d6fb6acfec364625cffbb1cf420346fb37c0
   React-NativeModulesApple: 46745aba687c1019983d56b6d5fa39265152f64f
   React-perflogger: 0d62c0261b6fd3920605850de91abc8135dd3ee9

diff --git a/examples/basic/ios/videoplayer.xcodeproj/project.pbxproj b/examples/basic/ios/videoplayer.xcodeproj/project.pbxproj
@@ -211,7 +211,7 @@
 					};
 				};
 			};
-			buildConfigurationList = 83CBB9FA1A601CBA00E9B192 /* Build configuration list for PBXProject "videoplayer" */;
+			buildConfigurationList = 83CBB9FA1A601CBA00E9B192 /* Build configuration list for PBXProject "VideoPlayer" */;
 			compatibilityVersion = "Xcode 12.0";
 			developmentRegion = en;
 			hasScannedForEncodings = 0;
@@ -619,7 +619,7 @@
 					"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers/react/renderer/components/view/platform/cxx",
 					"${PODS_CONFIGURATION_BUILD_DIR}/React-graphics/React_graphics.framework/Headers",
 				);
-				IPHONEOS_DEPLOYMENT_TARGET = 12.4;
+				IPHONEOS_DEPLOYMENT_TARGET = 13.0;
 				LD_RUNPATH_SEARCH_PATHS = (
 					/usr/lib/swift,
 					"$(inherited)",
@@ -729,7 +729,7 @@
 					"${PODS_CONFIGURATION_BUILD_DIR}/React-Fabric/React_Fabric.framework/Headers/react/renderer/components/view/platform/cxx",
 					"${PODS_CONFIGURATION_BUILD_DIR}/React-graphics/React_graphics.framework/Headers",
 				);
-				IPHONEOS_DEPLOYMENT_TARGET = 12.4;
+				IPHONEOS_DEPLOYMENT_TARGET = 13.0;
 				LD_RUNPATH_SEARCH_PATHS = (
 					/usr/lib/swift,
 					"$(inherited)",
@@ -776,7 +776,7 @@
 			defaultConfigurationIsVisible = 0;
 			defaultConfigurationName = Release;
 		};
-		83CBB9FA1A601CBA00E9B192 /* Build configuration list for PBXProject "videoplayer" */ = {
+		83CBB9FA1A601CBA00E9B192 /* Build configuration list for PBXProject "VideoPlayer" */ = {
 			isa = XCConfigurationList;
 			buildConfigurations = (
 				83CBBA201A601CBA00E9B192 /* Debug */,

diff --git a/examples/exampletvOS/ios/Podfile.lock b/examples/exampletvOS/ios/Podfile.lock
@@ -78,9 +78,6 @@ PODS:
   - hermes-engine/Pre-built (0.71.12-0)
   - libevent (2.1.12.1)
   - OpenSSL-Universal (1.1.1100)
-  - PromisesObjC (2.3.1)
-  - PromisesSwift (2.3.1):
-    - PromisesObjC (= 2.3.1)
   - RCT-Folly (2021.07.22.00):
     - boost
     - DoubleConversion
@@ -319,12 +316,9 @@ PODS:
   - React-jsinspector (0.71.12-0)
   - React-logger (0.71.12-0):
     - glog
-  - react-native-video (6.0.0-alpha.8):
-    - React-Core
-    - react-native-video/Video (= 6.0.0-alpha.8)
-  - react-native-video/Video (6.0.0-alpha.8):
-    - PromisesSwift
+  - react-native-video (6.0.0-beta.6):
     - React-Core
+    - react-native-video/Video (= 6.0.0-beta.6)
   - React-perflogger (0.71.12-0)
   - React-RCTActionSheet (0.71.12-0):
     - React-Core/RCTActionSheetHeaders (= 0.71.12-0)
@@ -486,8 +480,6 @@ SPEC REPOS:
     - Flipper-RSocket
     - FlipperKit
     - OpenSSL-Universal
-    - PromisesObjC
-    - PromisesSwift
     - SocketRocket
 
 EXTERNAL SOURCES:
@@ -582,8 +574,6 @@ SPEC CHECKSUMS:
   hermes-engine: 3d04f537177e132da926803412639dacd59a0ee9
   libevent: a6d75fcd7be07cbc5070300ea8dbc8d55dfab88e
   OpenSSL-Universal: ebc357f1e6bc71fa463ccb2fe676756aff50e88c
-  PromisesObjC: c50d2056b5253dadbd6c2bea79b0674bd5a52fa4
-  PromisesSwift: 28dca69a9c40779916ac2d6985a0192a5cb4a265
   RCT-Folly: 136e9161a833a162fe3e8b647098759aae227036
   RCTRequired: 0c0d97ba9f1e2b2b70e0522d65992a2993a714cd
   RCTTypeSafety: 5a484bd8f18408b8918a668ac8bd8b9f9138142b
@@ -598,7 +588,7 @@ SPEC CHECKSUMS:
   React-jsiexecutor: 0c8c5e8b2171be52295f59097923babf84d1cf66
   React-jsinspector: f8e6919523047a9bd1270ade75b4eca0108963b4
   React-logger: 16c56636d4209cc204d06c5ba347cee21b960012
-  react-native-video: 86950ad481cec184d7c9420ec3bca0c27904bbcd
+  react-native-video: 98040e05dace82fbbe8709cf42fd4496b0aed744
   React-perflogger: 355109dc9d6f34e35bc35dabb32310f8ed2d29a2
   React-RCTActionSheet: 9d1be4d43972f2aae4b31d9e53ffb030115fa445
   React-RCTAnimation: aab7e1ecd325db67e1f2a947d85a52adf86594b7
@@ -617,4 +607,4 @@ SPEC CHECKSUMS:
 
 PODFILE CHECKSUM: 49dad183688257f9360c15d54e77f8de0f8048f7
 
-COCOAPODS: 1.12.1
+COCOAPODS: 1.13.0