Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android) : add rtsp support #2824

Closed

Conversation

freeboub
Copy link
Collaborator

@freeboub freeboub commented Aug 21, 2022

Enable RTSP support on android
Add sample url in basic sample

@freeboub freeboub mentioned this pull request Aug 21, 2022
@freeboub freeboub marked this pull request as draft September 11, 2022 15:15
olivier bouillet added 6 commits January 2, 2023 23:04
…native-video into feat/add_rtsp_support

# Conflicts:
#	Video.js
#	android/build.gradle
#	android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
#	android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java
#	examples/basic/android/gradle.properties
#	examples/basic/yarn.lock
@freeboub freeboub changed the title [WIP] feat(android) : add rtsp support feat(android) : add rtsp support Jan 3, 2023
@freeboub freeboub marked this pull request as ready for review January 3, 2023 20:21
@freeboub freeboub mentioned this pull request Jan 3, 2023
olivier added 2 commits December 11, 2023 22:12
…native-video into feat/add_rtsp_support

# Conflicts:
#	API.md
#	Video.js
#	android/build.gradle
#	android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java
#	examples/basic/android/build.gradle
#	examples/basic/package.json
#	examples/basic/src/VideoPlayer.android.tsx
#	examples/basic/yarn.lock
@Michota
Copy link

Michota commented Apr 10, 2024

Why this is not merged yet?

@VMBindraban
Copy link

@freeboub Can this be merged?

@freeboub
Copy link
Collaborator Author

@VMBindraban @Michota were you able to test this PR successfully?

@VMBindraban
Copy link

VMBindraban commented Apr 15, 2024

@freeboub I am getting a back screen when i try to load rtsp://rtspstream:[email protected]/movie (made the url invalid due 2 GB bandwidth limitation)

04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal: Playback error
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:   androidx.media3.exoplayer.ExoPlaybackException: Source error
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.ExoPlayerImplInternal.handleIoException(ExoPlayerImplInternal.java:684)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:656)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at android.os.Handler.dispatchMessage(Handler.java:102)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at android.os.Looper.loopOnce(Looper.java:205)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at android.os.Looper.loop(Looper.java:294)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at android.os.HandlerThread.run(HandlerThread.java:67)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:   Caused by: androidx.media3.datasource.HttpDataSource$HttpDataSourceException: Malformed URL
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at androidx.media3.datasource.okhttp.OkHttpDataSource.makeRequest(OkHttpDataSource.java:418)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at androidx.media3.datasource.okhttp.OkHttpDataSource.open(OkHttpDataSource.java:311)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at androidx.media3.datasource.DefaultDataSource.open(DefaultDataSource.java:272)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at androidx.media3.datasource.StatsDataSource.open(StatsDataSource.java:86)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.source.ProgressiveMediaPeriod$ExtractingLoadable.load(ProgressiveMediaPeriod.java:1006)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at androidx.media3.exoplayer.upstream.Loader$LoadTask.run(Loader.java:414)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
04-15 11:47:06.781  5819  6072 E ExoPlayerImplInternal:       at java.lang.Thread.run(Thread.java:1012)

Plays fine in VLC.

@freeboub
Copy link
Collaborator Author

@VMBindraban ok, it explains why it is not merged. Can you explain how you setup your sample stream please ? Last time I tried i wasn't able to setup vlc as rtsp stream server... (I have lost my notes on my initial test)

@VMBindraban
Copy link

I am using a free RTSP stream service: https://rtsp.stream/

@freeboub freeboub mentioned this pull request Apr 15, 2024
@freeboub
Copy link
Collaborator Author

Ok thank you for the sample stream, I was able to test it successfully and add a sample stream in demo app, let continue in: #3677

@freeboub freeboub closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants