Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit SDK version for Windows builds #3246

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

chrisglein
Copy link
Contributor

@chrisglein chrisglein commented Sep 18, 2023

Fix SDK build error if 10.0.16299.0 is not installed:

 i Build configuration: Debug
 i Build platform: x64
 × Build failed with message 4:10>C:\Users\redactedUser\.nuget\packages\microsoft.ui.xaml\2.8.0\build\Common.targets(10,5): error : Microsoft.UI.Xaml nuget package requires TargetPlatformMinVersion >= 10.0.17763.0 (current project is 16299) [D:\GitHub\redacted\node_modules\react-native-video\windows\ReactNativeVideoCPP\ReactNativeVideoCPP.vcxproj]. Check your build configuration.

See react-native-async-storage/async-storage#810 for a similar fix.
And these

Previously, after bringing down package dependencies you'd have to retarget the SDK version for the module project.

This change was tested by applying a patch-package of the vcxproj to an RNW app and doing a clean build. Basically, if it builds, it's good. No runtime effect.

  • After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.

@freeboub
Copy link
Collaborator

This is ok for me, thank you for these pull requests. Just a question, does it imply some necessary change on the application side to configure the sdk ? I think no, but I am asking as I am in doubt !

@chrisglein
Copy link
Contributor Author

This is ok for me, thank you for these pull requests. Just a question, does it imply some necessary change on the application side to configure the sdk ? I think no, but I am asking as I am in doubt !

Nope, no change needed on the application side. If the app has an SDK version specified (which it absolutely will have) then this module will match that SDK version with this change. Previously it would fight with the app's specified SDK and you'd need to have both SDK versions installed in order to build. Which could have been transparent if you happened to have multiple SDKs installed, or would be a nuisance to prompt you to go install an SDK version you didn't really need (and also be a drain on your disk space 😉).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants