-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add custom image metadata option for iOS and add missing types for custom metadata properties #3280
chore: add custom image metadata option for iOS and add missing types for custom metadata properties #3280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor clarification expected, else this is ok for me
@@ -981,7 +981,7 @@ Platforms: iOS, Android | |||
|
|||
##### Overriding the metadata of a source | |||
|
|||
Provide an optional `title`, `subtitle` and/or `description` properties for the video. | |||
Provide an optional `title`, `subtitle`, `customImageUri` and/or `description` properties for the video. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any limitation for the image ?
I see the internal tvOS api need a png, but not clear if a png is mandatory in the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No the API supports the image formats supported by UIImage, which contains the classic ones like jpeg, png.
The list can be found here:
notice also that you have linter error ... /home/runner/work/react-native-video/react-native-video/src/Video.tsx ✖ 1 problem (1 error, 0 warnings) error Command failed with exit code 1. You can keep the sample as is. @KrzysztofMoch said you will have a look to the sample ! |
I only added this line as the selectedtexttracks contained a type issue, blocking the typescript compile operation. |
@Duell10111 There is fix on master for this ts error and for eslint errors, you can make rebase 😁 |
I was able to fix it :) So let's merge ! |
Update the documentation
Updated the API.md with the new imageMetadataUri
Provide an example of how to test the change
Can be tested in the tvOS example of the app
Describe the changes
Added a possibillity to modify the image metadata of a video shown in tvOS for example or the Now Playing area in iOS.
Created as descripted in the documentation of apple:
https://developer.apple.com/documentation/avkit/customizing_the_tvos_playback_experience#3820220