Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update types #3288

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: update types #3288

merged 1 commit into from
Oct 11, 2023

Conversation

KrzysztofMoch
Copy link
Member

Summary

Fix types

fixes #3287

Test Plan

  • prop selectedTextTrack should work
  • prop selectedAudioTrack should work

@KrzysztofMoch
Copy link
Member Author

Test are failing due to CI node version - created PR #3289 to fix it

@KrzysztofMoch KrzysztofMoch mentioned this pull request Oct 11, 2023
Closed
@freeboub freeboub merged commit 5c3baca into TheWidlarzGroup:master Oct 11, 2023
1 check failed
@KrzysztofMoch KrzysztofMoch deleted the fix/types branch October 26, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub Awaiting requested review from freeboub

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SelectedTracks
2 participants
@KrzysztofMoch @freeboub