-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sample): fix lint and ts sample #3365
chore(sample): fix lint and ts sample #3365
Conversation
examples/basic/android/app/src/main/java/com/videoplayer/MainApplication.java
Outdated
Show resolved
Hide resolved
…native-video into chore/fixLintAndTSSample # Conflicts: # examples/basic/yarn.lock
@KrzysztofMoch I backport your CI changes to be able to build the sample in this (Thank you again for that). |
tI don't understand why I don't see my initial changes /o\ |
You can create separate "job" in build file so we will have build for Ads and build with non ads |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
start fix eslint and tsc warnings in the sample