Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sample): fix lint and ts sample #3365

Merged
merged 12 commits into from
Nov 30, 2023

Conversation

freeboub
Copy link
Collaborator

start fix eslint and tsc warnings in the sample

@freeboub
Copy link
Collaborator Author

@KrzysztofMoch I backport your CI changes to be able to build the sample in this (Thank you again for that).
I want to enhance it be able to build with different build option (with or without ads typically).
What do you advise ? copy build-.yml to build--withads.yml or directly patch the file with something like:
run: cd examples/basic/android && ./gradlew assembleDebug --build-cache && ./gradlew clean && export ENABLE_ADS=true && ./gradlew assembleDebug --build-cache && cd ../../..

@freeboub
Copy link
Collaborator Author

tI don't understand why I don't see my initial changes /o\

@KrzysztofMoch
Copy link
Member

@KrzysztofMoch I backport your CI changes to be able to build the sample in this (Thank you again for that).

I want to enhance it be able to build with different build option (with or without ads typically).

What do you advise ? copy build-.yml to build--withads.yml or directly patch the file with something like:

    run: cd examples/basic/android && ./gradlew assembleDebug --build-cache  && ./gradlew clean && export ENABLE_ADS=true && ./gradlew assembleDebug --build-cache && cd ../../..

You can create separate "job" in build file so we will have build for Ads and build with non ads

Copy link
Member

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@freeboub freeboub merged commit 4728201 into TheWidlarzGroup:master Nov 30, 2023
7 checks passed
@KrzysztofMoch KrzysztofMoch mentioned this pull request Dec 1, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants