feat: implement capture method #3577
Conversation
| @@ -68,6 +68,7 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH | |||
| private var _presentingViewController: UIViewController? | |||
| private var _pictureInPictureEnabled = false | |||
| private var _startPosition: Float64 = -1 | |||
| private var _playerOutput: AVPlayerItemVideoOutput? | |||
There was a problem hiding this comment.
Does it increase memory usage significantly ?
There was a problem hiding this comment.
As I know, it depends on resolution or bitrate
YangJonghun
force-pushed
the
feat/capture-method
branch
from
8c5e4da to
a7feb7e
Compare
| @@ -265,6 +266,13 @@ const Video = forwardRef<VideoRef, ReactVideoProps>( | |||
| return VideoManager.setPlayerPauseState(false, getReactTag(nativeRef)); | |||
| }, []); | |||
|
|
|||
| const capture = useCallback(() => { | |||
| if (drm) { | |||
| throw Error('"capture" method can not be called with "drm" prop'); | |||
There was a problem hiding this comment.
throwing an exception is a bit violent ? console.warn should be enough ?
There was a problem hiding this comment.
And BTW, you may defined an empty object in drm... I think you can just remove the test and handle it correctly in native code !
|
|
||
| <PlatformsList types={['iOS', 'Android']} /> | ||
|
|
||
| `capture(): Promise<void>` |
There was a problem hiding this comment.
Is it possible to manage the generate file here ?
2 solutions:
- allows to give a path / file path in parameters
- give the generated file path in promise result
Because, here, I cannot know where the file is generated
| import android.view.SurfaceView | ||
| import android.view.TextureView | ||
| import android.view.View | ||
| import androidx.media3.common.util.Util |
There was a problem hiding this comment.
This import should not be in common folder : import androidx.media3.common.util.Util
Any way to remove it ?
|
@freeboub @KrzysztofMoch |
Summary
Implement capture method
Motivation
Actually this feature(save image file) doesn't related player feature, but it is so much hard to implement within JS side or other native module. so I create this PR.
(If it doesn't fit your development plan, please close it.)
Changes
add method named
captureTest plan
just call
await videoRef.current.capture()without below propsand check below setup