fix(ios): ensure playback stopped in background #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and review onBuffer event (not yet clean)
freeboub
changed the title
KrzysztofMoch
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix: #3568 and #2954
Do not pause playback in handlePlaybackLikelyToKeepUp and in seek call
start reviewing onBuffer event (not yet clean)
Motivation
It doesn't make sens to pause the playback in that case. see apple documentation about this event: https://developer.apple.com/documentation/avfoundation/avplayeritem/1390348-playbacklikelytokeepup
Even if buffer is empty, we don't want to pause the playback, the player shall automatically resume it.
Test plan
Tested with the sample.
I also ensure pip works fine