fix(ios): ensure orientation is correct on iOS#3719
Merged
KrzysztofMoch merged 8 commits intoTheWidlarzGroup:masterfrom Apr 26, 2024
Merged
fix(ios): ensure orientation is correct on iOS#3719KrzysztofMoch merged 8 commits intoTheWidlarzGroup:masterfrom
KrzysztofMoch merged 8 commits intoTheWidlarzGroup:masterfrom
Conversation
KrzysztofMoch
approved these changes
Apr 26, 2024
KrzysztofMoch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ensure orientation is well reported on ios
Motivation
Fix: #3705
Changes
Fix computation of orientation.
I removed videoTrack.preferredTransform as it is deprecated and it doesn't make sens in that part of code.
Test plan
Sample video added in the sample