Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/text track selection by index ios #3728

Merged
merged 11 commits into from
May 4, 2024
Merged

Fix/text track selection by index ios #3728

merged 11 commits into from
May 4, 2024

Conversation

freeboub
Copy link
Collaborator

@freeboub freeboub commented May 2, 2024

Summary

Apply type change (done for codegen) on selected track by index on ios.

Motivation

Make subtitles working ! see #3704

Changes

  • Fix selected track type (always string now)
  • Update sample to be able to retest selection by index easilly

Test plan

  • can be tested with sample
  • BTW, selection by index doesn't work on sideLoaded text tracks

freeboub added 11 commits April 3, 2024 22:19
@freeboub
fix(ts): onPlaybackRateChangeData was not correctly typed
417bd7a
@freeboub
Merge branch 'master' of github.com:react-native-video/react-native-v…
85fb438 
…ideo
@freeboub
fix: ensure tracks are well displayed in the sample
52b8ec1
@freeboub
Merge branch 'master' of github.com:react-native-video/react-native-v…
5ca679d 
…ideo
@freeboub
Merge branch 'master' of github.com:react-native-video/react-native-v…
39ac06d 
…ideo
@freeboub
Merge branch 'master' of github.com:react-native-video/react-native-v…
b92954a 
…ideo
@freeboub
Merge branch 'master' of github.com:react-native-video/react-native-v…
2019395 
…ideo
@freeboub
Merge branch 'master' of github.com:react-native-video/react-native-v…
66d1d4d 
…ideo
@freeboub
fix(ios): text tracks selection by index. regression due to codegen r…
25a5438 
…ework
@freeboub
chore: make selection by index testable (need a small manual patch)
2d18146
@freeboub
chore(ios): fix linter warning
62a3420
@freeboub freeboub requested a review from KrzysztofMoch May 2, 2024 13:02
KrzysztofMoch
KrzysztofMoch approved these changes May 4, 2024
View reviewed changes
Copy link
Member

@KrzysztofMoch KrzysztofMoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KrzysztofMoch KrzysztofMoch merged commit 51e22ab into TheWidlarzGroup:master May 4, 2024
6 checks passed
@freeboub freeboub mentioned this pull request May 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KrzysztofMoch KrzysztofMoch KrzysztofMoch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freeboub @KrzysztofMoch