Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): call onLoadStart earlier #3750

Merged
merged 4 commits into from
May 13, 2024
Merged

fix(ios): call onLoadStart earlier #3750

merged 4 commits into from
May 13, 2024

Conversation

KrzysztofMoch
Copy link
Member

@KrzysztofMoch KrzysztofMoch commented May 10, 2024 •
edited
Loading

Summary

call callback onLoadStart earlier to make it work properly

Motivation

fix #3744

Changes

  • move callback onLoadStart earlier
  • don't call onVideoBuffer in handlePlaybackLikelyToKeepUp if value is same as previous

Test plan

  • Tested Locally
  • CI pass

@KrzysztofMoch KrzysztofMoch requested a review from freeboub May 10, 2024 13:16
@freeboub
Copy link
Collaborator

I think this change may also fix: #3675

@KrzysztofMoch KrzysztofMoch requested a review from freeboub May 13, 2024 17:35
@KrzysztofMoch KrzysztofMoch merged commit b3f08f6 into TheWidlarzGroup:master May 13, 2024
6 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/ios-onvideoloadstart branch May 13, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onBuffer & onLoadStart not working properly
2 participants
@KrzysztofMoch @freeboub