Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): don't crash app if view wasn't found #3841

Merged

Conversation

KrzysztofMoch
Copy link
Member

Summary

Change RCTError to DebugLog to fix App crashes that are using react-native-video with Interop Layer (new arch)

I have an app where this issue appears and this patch is fixing it

Motivation

Fix App crashes that are using react-native-video with Interop Layer (new arch)

Changes

  • change RCTError to DebugLog
  • add additional variable to make DebugLog message working correctly

Test plan

  • Run basic app with new arch
  • Crash should happen when using ref functions

@KrzysztofMoch KrzysztofMoch requested a review from freeboub May 26, 2024 17:25
@KrzysztofMoch KrzysztofMoch merged commit cd28d37 into TheWidlarzGroup:master May 27, 2024
6 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/ios-ref-newarch branch May 27, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants