chore: move sample to expo #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oplayerView code size
…ideo # Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java # src/Video.tsx
…fix/avoidVideoResizingFlickering # Conflicts: # .github/ISSUE_TEMPLATE/bug-report.yml
KrzysztofMoch
approved these changes
Jun 10, 2024
examples/basic/package.json
Outdated
| @@ -14,6 +14,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@react-native-picker/picker": "2.7.5", | |||
| "expo": "^51.0.0", | |||
There was a problem hiding this comment.
Also I think we should update deps (as expo cli says)
[email protected] - expected version: ~51.0.11
[email protected] - expected version: 0.74.2
@babel/[email protected] - expected version: ^7.24.0
@types/[email protected] - expected version: ~18.2.79
[email protected] - expected version: ~5.3.3
…ideo into chore/moveSampleToExpo
Co-authored-by: Krzysztof Moch <[email protected]>
…tive-video into chore/moveSampleToExpo
|
@freeboub, can we merge this ? |
|
@KrzysztofMoch yhere is an issue with local asset I would like to fix (and document) before merging ... |
|
I just retest the branch and it works fine 🤔 So it is OK for merging ! |
|
@KrzysztofMoch The crash I found shall be fixed by: #3915 ... |
|
I will merge this as PR with crash fix is merged and CI is passing |
|
@freeboub @KrzysztofMoch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
move sample to expo
Motivation
now expo is the standard way to work with react native
Changes
Add expo support
Test plan
With sample