Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): missing notification controls when enabled from start #3898

Merged
merged 2 commits into from
Jun 12, 2024
Merged

fix(ios): missing notification controls when enabled from start #3898

merged 2 commits into from
Jun 12, 2024

Conversation

KrzysztofMoch
Copy link
Member

Summary

Fix notification controls don't show up when set to true on start

Motivation

fixes #3890

Changes

  • set _showNotificationControls even if _player is nil

Test plan

Tested on real device

@KrzysztofMoch KrzysztofMoch requested a review from freeboub June 12, 2024 07:51
@KrzysztofMoch KrzysztofMoch merged commit 2d793db into TheWidlarzGroup:master Jun 12, 2024
6 checks passed
@KrzysztofMoch KrzysztofMoch deleted the fix/ios-notification-controls-from-init branch June 16, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freeboub freeboub freeboub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: missing notification controls if showNotificationControls initially is set to true on IOS
2 participants
@KrzysztofMoch @freeboub