-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): detect livestreams in now playing notification #3922
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides comment from freeboub, It looks good to me
Using @YangJonghun 's suggestion worked, live videos show as live and normal show as normal ones in As a side note, I tried the metadata way and that was not working, though it was fairly complex due to the iOS types so that is where it could have not worked correctly. Although passing a flag via metadata seemed, it may not be possible. |
That works for me ! Thank you |
Corrected the styling. |
…am playing
This addresses part of #3902
Apple however does encourage going further, "Consider indicating the progress of currently playing live content. People appreciate knowing where they’ll land when they jump into in-progress live content. You can use a progress bar or other indicator to show people how much content remains." (source: Apple Design Guidelines). However , Apple does not indicate if this goes for the minimal view of a Now Playing view. So this may be sufficient for many developers and audiences.
To test the change,
show notification controls
on the ui,Summary
Adds "LIVE" decorator to livestream notification (now playing)
Playback (can't remember which it was in example):
Live (red bull live, another live sample):
Motivation
Saw that livestreams in our app show just ---- ---- which is what some apps (AP News, CNN (their pause/play doesn't work correctly though)) do on iOS but a few we saw show a LIVE decorator. To ensure our audience understand what is being shown, we should add this code.
iOS Apps that show --_-- on each side of a livestream now playing control center view: Fox (doesn't allow background play), FM Radio, NBC
Changes
Added a check to determine if live content is currently playing
Test plan
None