-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEMO] plugin showcase #3943
Closed
Closed
[DEMO] plugin showcase #3943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oplayerView code size
…ideo # Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java # src/Video.tsx
…fix/avoidVideoResizingFlickering # Conflicts: # .github/ISSUE_TEMPLATE/bug-report.yml
* fix: ensure player doesn't start when view is unmounted
…ideo into feat/addAnalyticsPlugManagement # Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerView.java # examples/basic/ios/Podfile.lock
…/react-native-video into feat/addAnalyticsPlugManagement # Conflicts: # examples/basic/ios/Podfile.lock
…feat/addAnalyticsPlugManagement
…ideo into feat/addAnalyticsPlugManagement # Conflicts: # examples/basic/ios/Podfile.lock # examples/basic/ios/videoplayer.xcodeproj/project.pbxproj # examples/basic/tsconfig.json
…/react-native-video into tmp
…ideo into feat/allowBuildingFromExoplayerSource
…ideo into chore/pluginTest # Conflicts: # docs/pages/other/plugin.md # examples/react-native-video-plugin-sample/android/build.gradle # examples/react-native-video-plugin-sample/android/src/main/java/com/videopluginsample/VideoPluginSampleModule.kt
…eeboub/react-native-video into chore/pluginTest # Conflicts: # android/build.gradle # examples/basic/android/app/build.gradle # examples/basic/android/settings.gradle # examples/react-native-video-plugin-sample/android/build.gradle
…ideo into chore/pluginTest # Conflicts: # examples/basic/android/build.gradle # examples/basic/android/settings.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is not intended to be merged. It shows improvements from version 6.5.0.
Motivation
This is a proof of concept of thumbnail display in the sample. I added the thumbnail over the seek bar dynamically in the UI.
Changes
Demo
sample_video.webm