Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ios build issue (revert #3682) #4244

Closed
wants to merge 3 commits into from

Conversation

mid2ly
Copy link

@mid2ly mid2ly commented Oct 19, 2024

Summary

Revert #3682

Motivation

after fixing #3682, the issue presented in #3152 re-occurs.

Changes

Add RCTEventDispatcher.h to RCTVideo-Bridging-Header.h

Test plan

build on Xcode

@mid2ly mid2ly marked this pull request as draft October 19, 2024 01:41
@mid2ly mid2ly closed this Oct 19, 2024
@mid2ly mid2ly reopened this Oct 19, 2024
@mid2ly mid2ly marked this pull request as ready for review October 19, 2024 01:43
@freeboub
Copy link
Collaborator

freeboub commented Nov 24, 2024

I just see that you have updated this PR.
I think this is painful, but it has already been integrated and reverted.

Can you please test this patch and provide me the error output (if any 🤞 )

diff --git a/ios/Video/Features/DRMManager.swift b/ios/Video/Features/DRMManager.swift
index 0b3facd3..aa9650ee 100644
--- a/ios/Video/Features/DRMManager.swift
+++ b/ios/Video/Features/DRMManager.swift
@@ -6,6 +6,7 @@
 //
 
 import AVFoundation
+import React
 
 class DRMManager: NSObject {
     static let queue = DispatchQueue(label: "RNVideoContentKeyDelegateQueue")
diff --git a/ios/Video/Features/RCTVideoSave.swift b/ios/Video/Features/RCTVideoSave.swift
index cdf1fdf9..2c6aa207 100644
--- a/ios/Video/Features/RCTVideoSave.swift
+++ b/ios/Video/Features/RCTVideoSave.swift
@@ -1,4 +1,5 @@
 import AVFoundation
+import React
 
 enum RCTVideoSave {
     static func save(
diff --git a/ios/Video/RCTVideo-Bridging-Header.h b/ios/Video/RCTVideo-Bridging-Header.h
index 6522d5ae..488620ea 100644
--- a/ios/Video/RCTVideo-Bridging-Header.h
+++ b/ios/Video/RCTVideo-Bridging-Header.h
@@ -1,6 +1,3 @@
-#import "RCTVideoSwiftLog.h"
-#import <React/RCTViewManager.h>
-
 #if __has_include(<react-native-video/RCTVideoCache.h>)
 #import "RCTVideoCache.h"
 #endif

@mid2ly
Copy link
Author

mid2ly commented Nov 25, 2024

@freeboub My Podfile was the issue. After fixing it, I verified that everything works fine from the version at the time of the PR (v6.7.0) to the latest version (v6.8.1).

In conclusion, there’s no problem with the project! Sorry for the confusion.

@mid2ly mid2ly closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants